Pinned
1,179 contributions in the last year
Less
More
Activity overview
Contribution activity
April 2021
Created 14 commits in 4 repositories
Created 2 repositories
- Hixie/devtools Dart
- Hixie/isd C++
Created a pull request in flutter/tests that received 8 comments
Add skp_generator package
This script generates SKP images from various Flutter scenes for testing in Skia's automated systems. Fixes flutter/flutter#80884
+653
−4
•
8
comments
Opened 12 other pull requests in 3 repositories
flutter/flutter
4
open
5
merged
1
closed
- Add skp_generator shard to LUCI config
- Fix race condition in overall_experience_test
- Apply style guide regarding createTempSync pattern
- Test the skp_generator.
- Use "aliases" in args to fix some technical debt
- Update to latest args
- Clean up the command line tool interactive help output.
- Change --disable-dds to --no-dds to avoid double negatives
- Move ExpansionPanelList to Canvas.drawShadow
- Refactor text editing test APIs (Mark III)
flutter/infra
1
merged
flutter/tests
1
merged
Reviewed 18 pull requests in 5 repositories
flutter/flutter 11 pull requests
- Enable dryLayoutSize cache for performResize
- Move ExpansionPanelList to Canvas.drawShadow
- create SDK package allowlist for core packages
- better document setState
- Fix the problem of too fast playback of some gifs
- improve issue templates
- [flutter_tools] dont require a device for screenshot type skia/rasterizer
- Add prototypeItem property to ListView
- Refactor text editing test APIs
-
enterTextto move the caret to the end - Correct misspellings throughout the codebase
flutter/engine 3 pull requests
flutter/tests 2 pull requests
flutter/infra 1 pull request
flutter/website 1 pull request
Created an issue in flutter/flutter that received 4 comments
debugDumpRenderTree returning null crashes the tool
Looks like we need to make the tool more resilient to getting nulls from the framework. For example, run Flutter in a way that doesn't hook the bin…
4
comments
Opened 12 other issues in 2 repositories
flutter/flutter
7
open
4
closed
- Jump to index in sliver world
- Refactor how the flutter tool handles --machine output
- Add a test for skp_generator in flutter/tests to flutter/flutter
-
flutter testshould have afail on stdoutoption - "flutter screenshot --type=device --observatory-uri=..." should warn that it's ignoring the Observatory URI
- Can't take an SKP screenshot of flutter-tester
- "flutter screenshot" requires a project and gets really confused without one
- MergableMaterial should use drawShadow instead of BoxShadow
- Remove "--dump-skp-on-shader-compilation" and all related code in engine and tool
- Linux desktop doesn't wire up the persistent cache
- Colons in flutter create --description don't get escaped in pubspec.yaml