Skip to content
#

infrastructure-as-code

Here are 1,073 public repositories matching this topic...

danielrobbins
danielrobbins commented Mar 20, 2021

We have Changelog documentation here:

https://docs.saltproject.io/en/latest/topics/development/changelog.html

However, this documentation is not integrated or referenced in our documentation on how to create PRs:

https://docs.saltproject.io/en/latest/topics/development/contributing.html

The "Changelog" section appears BEFORE the Contributing section, but should likely be placed INSIDE

vilikin
vilikin commented Apr 26, 2021

DatabaseCluster should have instanceIdentifiers and instanceEndpoints props available. However, it looks like these are always empty.

From the code we can see that those are not actually set to the right values returned by the createInstances method:
https://github.com/aws/aws-cdk/blob/55e737ffb378cc8690b201a6c52424102dee9c3b/packages/%40aws-cdk/aws-rds/lib/cluster.ts#L527

Reproduct

anguslees
anguslees commented Mar 21, 2018

Garbage collection works by listing everything with the gc-tag. In a busy cluster, we really want that filter to happen server-side and ideally using an index of some sort.

That means we should use a Kubernetes label, not an annotation.

I think this will require a two-step migration plan (write both but continue to read annotation; release; drop support for annotation; release).

Improve this page

Add a description, image, and links to the infrastructure-as-code topic page so that developers can more easily learn about it.

Curate this topic

Add this topic to your repo

To associate your repository with the infrastructure-as-code topic, visit your repo's landing page and select "manage topics."

Learn more