Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buffer: remove unreachable code #38537

Closed
wants to merge 1 commit into from
Closed

buffer: remove unreachable code #38537

wants to merge 1 commit into from

Conversation

@pd4d10
Copy link
Contributor

@pd4d10 pd4d10 commented May 4, 2021

The condition nb > targetLen is always false because of line 241-242

@nodejs-github-bot
Copy link

@nodejs-github-bot nodejs-github-bot commented May 4, 2021

@nodejs-github-bot
Copy link

@nodejs-github-bot nodejs-github-bot commented May 4, 2021

@Trott
Trott approved these changes May 6, 2021
@Trott
Copy link
Member

@Trott Trott commented May 6, 2021

@jasnell
jasnell approved these changes May 7, 2021
@jasnell
Copy link
Member

@jasnell jasnell commented May 7, 2021

Landed in df8af88

@jasnell jasnell closed this May 7, 2021
jasnell added a commit that referenced this pull request May 7, 2021
PR-URL: #38537
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@pd4d10 pd4d10 deleted the pd4d10:patch-5 branch May 7, 2021
targos added a commit that referenced this pull request May 17, 2021
PR-URL: #38537
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos added a commit that referenced this pull request May 30, 2021
PR-URL: #38537
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos added a commit that referenced this pull request Jun 5, 2021
PR-URL: #38537
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos added a commit that referenced this pull request Jun 5, 2021
PR-URL: #38537
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos added a commit that referenced this pull request Jun 11, 2021
PR-URL: #38537
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants