Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement popover component and beginnings of color picker #128

Merged
merged 1 commit into from May 17, 2021

Conversation

@Keavon
Copy link
Member

@Keavon Keavon commented May 17, 2021

This change is Reviewable

@Keavon Keavon requested a review from TrueDoctor May 17, 2021
@Keavon
Copy link
Member Author

@Keavon Keavon commented May 17, 2021

@Keavon Keavon force-pushed the popover-and-color-picker-components branch from ae9ea99 to 9f8c61b May 17, 2021
@cloudflare-pages
Copy link

@cloudflare-pages cloudflare-pages bot commented May 17, 2021

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 9f8c61b
Status:   Deploy successful!
Preview URL: https://d854739d.graphite-master.pages.dev

View logs

@Keavon Keavon changed the title Implement primary/secondary colors and HSV picker Implement popover component and beginnings of color picker May 17, 2021
@TrueDoctor
Copy link
Member

@TrueDoctor TrueDoctor commented May 17, 2021

Is it possible to make the color picker go away when you click somewhere else on the screen?

@Keavon
Copy link
Member Author

@Keavon Keavon commented May 17, 2021

Yes, but that's an extra layer of complexity I will be adding to the popover system later.

Copy link
Member

@TrueDoctor TrueDoctor left a comment

Looks fine as far as I can tell

Reviewed 5 of 5 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Keavon)

@Keavon Keavon merged commit b20adda into master May 17, 2021
3 checks passed
3 checks passed
@github-actions
build build
Details
@cloudflare-pages
Cloudflare Pages Deployed successfully
Details
code-review/reviewable 5 files reviewed (Keavon)
Details
@Keavon Keavon deleted the popover-and-color-picker-components branch May 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants