josharian
Follow
Pinned
1,169 contributions in the last year
Less
More
Contribution activity
May 2021
Created 65 commits in 7 repositories
Created a pull request in tailscale/tailscale that received 7 comments
Opened 36 other pull requests in 4 repositories
tailscale/tailscale
1
open
20
merged
- net/packet: use netaddr AppendTo methods
- go.mod: upgrade netaddr to get AppendTo methods
- internal/deephash: add a few more benchmarking map entries
- all: adapt to opaque netaddr types
- cmd/tailscale: make ping --until-direct require direct connection to exit 0
- wgengine: remove wireguard-go DeviceOptions
- wgengine/wglog: optimize Logger.SetPeers
- internal/deepprint: improve benchmark
- wgengine/bench: ignore "engine closing" errors
- internal/deepprint: optimize
- go.mod: pull in wintun alignment fix from upstream wireguard-go
- types/wgkey: optimize Key.ShortString
- tailcfg: optimize keyMarshalText
- wgengine/bench: fix race conditions and panics
- wgengine/userspace: delete HandshakeDone
- cmd/tailscale/cli: fix running from Xcode
- syncs: stop running TestWatchMultipleValues on CI
- all: make staticcheck happy on windows
- all: add extra information to serialized endpoints
- workflows: run staticcheck on more platforms
- wgenengine/magicsock: delete cursed tests
inetaf/netaddr
1
closed
3
open
8
merged
- shrink IPPrefix using intern.Value to handle zones and bits
- fuzz more invalid values
- use "invalid IPPrefix" instead of "invalid IP prefix"
- improve handling of invalid IPPorts
- correctly parse IPPrefix "::%0/00/80"
- add AppendTo method to IP, IPPort, and IPPrefix
- fix IP.BinaryMarshal handling of zero IP
- add Marshal method round trip fuzzers and additional corpus
- make types opaque
- add IPFrom4
- optimize IPPort.MarshalText
- optimize IPPrefix.MarshalText
tailscale/wireguard-go
1
closed
1
merged
inetaf/wf
1
merged
Reviewed 14 pull requests in 3 repositories
tailscale/tailscale 10 pull requests
- ipn: allow b to be nil in NewBackendServer
- Replaced old verbose flag with testing.Verbose
- internal/deephash: hash maps without sorting in the acyclic common case
- wgengine/wglog: optimize Logger.SetPeers
- internal/deepprint: optimize
- all: add extra information to serialized endpoints
- ipn{,/ipnserver}: delay JSON marshaling of ipn.Notifies
- cmd/tailscale/cli: fix running from Xcode
- ipn/ipnlocal: switch from testify to quicktest
- cmd/tailscale: make 'file cp' have better error messages on bad targets
inetaf/netaddr 3 pull requests
inetaf/wf 1 pull request
Created an issue in golang/go that received 12 comments
proposal: reflect: add alloc-free way retrieve value from Value
It is currently impossible to retrieve large values (e.g. [32]byte) from a reflect.Value without allocating. There are specialized getters for comm…
12
comments