Skip to content

/ ApplicationInsights-Java

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ETW Event names #1284

Draft
wants to merge 1 commit into
base: opentelemetry
from
Draft

Update ETW Event names #1284

wants to merge 1 commit into from

Conversation

@littleaj
Copy link
Member

littleaj commented Jul 17, 2020

No description provided.

@littleaj littleaj force-pushed the littleaj/update_event_names branch from 24cbe53 to e87b7ca Jul 18, 2020
@littleaj
rename events
Loading status checks…
1b0675d
@littleaj littleaj force-pushed the littleaj/update_event_names branch from e87b7ca to 1b0675d Jul 23, 2020
@heyams

This comment has been minimized.

Sign in to view
Copy link

heyams commented on etw/native/src/main/headers/etw_provider.h in 1b0675d Jul 23, 2020

Should this be #define INFO_EVENT_NAME "Info"? It seems that the logger level didn't match.

This comment has been minimized.

Sign in to view
Copy link
Member Author

littleaj replied Jul 23, 2020

No, this is intentional. We are matching event names to an existing schema.

This comment has been minimized.

Sign in to view
Copy link

heyams replied Jul 23, 2020

Cool 👍
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@littleaj @heyams
You can’t perform that action at this time.