-
Notifications
You must be signed in to change notification settings - Fork 241
Add image scan docs #413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add image scan docs #413
Conversation
docs/imagescan.md
Outdated
| messageTemplate: "update image" | ||
| ``` | ||
|
|
||
| Try pushing a new image tag, for example, `your.registry.com/repo/image:v1.0.3`. Wait for a while and there should be a new commit pushed into your git repository to change tag in deployment.yaml. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps we should use <tag> instead of v1.0.3
docs/imagescan.md
Outdated
| spec: | ||
| containers: | ||
| - name: slave | ||
| image: your.registry.com/repo/image:v1.0.2 # {"$imagescan": "test-scan"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here with the tag, perhaps: <image>:<tag>
docs/imagescan.md
Outdated
| !!! hint "Experimental" | ||
| This feature is considered as experimental feature. | ||
|
|
||
| Go to fleet.yaml and add the following section. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: fleet.yaml instead of fleet.yaml
|
This documentation should probably be more explicit about what a semver range is, with an example that isn't just Also I can't tell at a glance but I think this notion of semver requires that your image tags be along the lines of |
d568c39 to
cb1bd93
Compare
#378