Skip to content

Add image scan docs #413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 2, 2021
Merged

Conversation

StrongMonkey
Copy link
Contributor

messageTemplate: "update image"
```

Try pushing a new image tag, for example, `your.registry.com/repo/image:v1.0.3`. Wait for a while and there should be a new commit pushed into your git repository to change tag in deployment.yaml.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we should use <tag> instead of v1.0.3

spec:
containers:
- name: slave
image: your.registry.com/repo/image:v1.0.2 # {"$imagescan": "test-scan"}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here with the tag, perhaps: <image>:<tag>

!!! hint "Experimental"
This feature is considered as experimental feature.

Go to fleet.yaml and add the following section.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: fleet.yaml instead of fleet.yaml

@StrongMonkey StrongMonkey mentioned this pull request Jun 14, 2021
@philomory
Copy link

philomory commented Jul 14, 2021

This documentation should probably be more explicit about what a semver range is, with an example that isn't just "*" (it's worth noting that the SemVer spec doesn't include the word "range" at all, so you're left to guess whose notion of "range" we're using here). It's probably also worth explicitly calling out how prerelease versions are handled; for example, if you write >= 1.0.0, then no pre-release SemVer tag will be considered, but if you write >= 1.0.0-0 then they will be. I had to go digging through the source code to find out that we're using the Masterminds/semver library, and then go look at their readme to see how things worked.

Also I can't tell at a glance but I think this notion of semver requires that your image tags be along the lines of 1.2.3 and not v1.2.3, which may be worth noting as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants