jmagman
Follow
Pinned
2,314 contributions in the last year
Less
More
Contribution activity
June 2021
Created 34 commits in 4 repositories
Created a pull request in flutter/plugins that received 5 comments
[ios_platform_images] Add iOS unit tests
Add RunnerTests XCTest iOS target to example app that creates the plugin and asserts it's not nil, proving linking is set up correctly.
ios_platfor…
+238
−14
•
5
comments
Opened 31 other pull requests in 3 repositories
flutter/flutter
23
merged
1
open
- Revert "Set up iOS native integration_tests in ui example project"
- Set up iOS native integration_tests in ui example project
- Revert "Roll Engine from ced58ef9c13e to b9616cad9c7d (14 revisions)"
- Audit devicelab log streaming for nullability
- Revert "Roll Engine from ced58ef9c13e to 86dacc0aad71 (9 revisions)"
- Use -miphonesimulator-version-min when building App.framework for simulator
- Revert "Set up iOS native integration_tests in ui example project"
- Remove unnecessary reference to iOS configuration in README
- Add native iOS screenshots to integration_test
- Fix integration_test podspecs warnings
- Set up iOS native integration_tests in ui example project
- Fix iOS native integration_tests example project
- Migrate build_macos and web_test_compiler to null safety
- Add Designed by iPad attach destination for ARM macOS
- Fix assemble iOS codesign flag to support --no-sound-null-safety
- Migrate android application_package to null safety
- Mixed null safety in dev/devicelab
- Migrate application_package to null safety
- Revert "Roll Engine from 939fb62b303b to 2398a8c4f1c8 (7 revisions)"
- Migrate a few tool libraries to null safety
- Migrate iOS project migrations to null safety
- Migrate deferred_components_prebuild_validator to null safety
- Remove globals from android application_package
- Migrate project.dart and all dependencies to null safety
flutter/plugins
6
merged
flutter/infra
1
merged
Reviewed 46 pull requests in 5 repositories
flutter/flutter 36 pull requests
- Take screenshot when drive fails
- Fix watchOS build when companion app is configured with xcode variable
- Use -miphonesimulator-version-min when building App.framework for simulator
- Clean up podspec template
- [flutter_tools] remove mockito from resident web runner tests
- [flutter_tools] tweak README
- [versions] update dependencies
- Add native iOS screenshots to integration_test
- Set up iOS native integration_tests in ui example project
- [flutter_tools] fully remove mocks from resident_runner_test.dart
- adds build number of ios device in flutter devices command
- Migrate build_macos and web_test_compiler to null safety
- Add Designed by iPad attach destination for ARM macOS
- [flutter_tools] reduce mocking in error handling io
- Migrate application_package to null safety
- Update outdated ios setup link in error message
- [flutter_tools] remove more mocks from runner tests
- [flutter_tools] fully remove mocks from version_test.dart
- Migrate macrobenchmarks to null safety
- [flutter_tools] switch flutter sdk to dart format
- [flutter_tools] remove substantial mocking from version test
- Mark flaky tests in 'expression_evaluation_web_test' as skipped.
- Add option to stream logs to file for flutter logs and way to use it in devicelab runs
- [flutter_tools] remove more mocks from cache_test
- [flutter_tools] bail from printing if devtools launch fails
- Some pull request reviews not shown.
flutter/plugins 7 pull requests
flutter/cocoon 1 pull request
flutter/website 1 pull request
google/file.dart 1 pull request
Created an issue in flutter/flutter that received 20 comments
Cirrus task failed: Error getting access token for service account, Invalid JWT Signature
Error getting access token for service account: 400 Bad Request POST https://oauth2.googleapis.com/token {"error":"invalid_grant","error_descriptio…
20
comments
Opened 23 other issues in 2 repositories
flutter/flutter
9
closed
13
open
- UIImagePickerController is deprecated in iOS 15
- Some devicelab tests are crashing locally, IosDevice.stopLoggingToSink NoSuchMethodError: The method 'kill' was called on null.
- Engine roll caused post-submit framework failures
- Read/write access to Flutter Xcode CIPD packages
- Update iOS and macOS engine builders to Xcode 12.0
- Build ARM during Mac Host Engine build
- Still see iOS and Android devices after turning off iOS and Android development via "flutter config --no-enable-ios" and "--no-enable-android"
- [tool_crash] ProcessException: Process exited abnormally:Command line invocation: xcodebuild -list, OS error code: -11
- Infra Failure: Step('install xcode') (retcode: 1)
- camera plugin test -[CameraOrientationTests testOrientationNotifications] Failed to set device orientation: Not authorized for performing UI testing actions
- Implement "flutter build macos --config-only"
-
expression_evaluation_web_test failed, "Exception: Received app.stop event while waiting for app.started event", causing
Linux web_tool_tests2.29% flaky - Some tests do not automatically rerun to detect flakes
- toggle_buttons_test "VerticalDirection test when direction is vertical" never completed, Dart Error: Dart_GetNativeFieldsOfArgument: expected 2 'num_fields' but was passed in 2
- LUCI tasks are pending and not being scheduled
- Show Run and queue time in cocoon build dashboard as minutes instead of seconds
- Multiple tests timing out "Waiting for observatory port to be available"
- [tool_crash] NoSuchMethodError: The getter 'uri' was called on null.Receiver: nullTried calling: uri
- thread_CastError: Null check operator used on a null value in LocalizationsGenerator describeLocale
- docs_test failed: tool execution failed: git status exit with non-zero exit code: -1284960497
- google_sign_in example app shows Error 401: deleted_client The OAuth client was deleted
- Include PATH in output of flutter doctor --verbose