Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAllowing for Key and Column attributes, and continue on key. #258
Conversation
added 2 commits
May 24, 2019
added 2 commits
Jun 6, 2019
ahmad-moussawi
force-pushed the
sqlkata:master
branch
6 times, most recently
from
f9a6417
to
a30bb49
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
rwood commentedMay 24, 2019
CacheDictionaryProperties wasn't being used.... should it?
There was an error if the Key attribute and Column attribute were both on a property. Since Key inherits from Column
var colAttr = property.GetCustomAttribute(typeof(ColumnAttribute)) as ColumnAttribute;threw an exception.Another error, when the Key attribute was present the column and value were added to the Where clause, but then also added to the Set clause. This throws an exception from the db (at least on SQL Server). Adding a
continue;to skip the Set clause for the Key.