dgreif
Follow
Pinned
524 contributions in the last year
Less
More
Contribution activity
May 2021
Created 48 commits in 5 repositories
Created a pull request in primer/components that received 5 comments
fix(SelectPanel): auto scroll when list overflows
Currently, SelectPanel is allowing the list contents to overflow. This change brings back overflow: auto behavior. It also adds scrollIntoView that…
+123
−20
•
5
comments
Opened 18 other pull requests in 1 repository
primer/components
18
merged
- fix(focusTrap): prevent blur if trap container is not in DOM
- fix(ActionList): description font size and truncation
-
feat(SelectPanel): allow
filterValueto be provided - Hide overflow from Overlay
- fix(ConfirmationDialog): use correct border radius on buttons
- fix: allow focus to move from overlay on mousedown
- feat(SelectPanel): active descendant focus
- Use item index as fallback key within groups
- New sizes for Overlay and Dialog
-
feat:
Spinnercomponent -
Add
no-unnecessary-conditionlint rule -
refactor(focusZone): remove
currentFocusedIndex - fix(focusZone): handle complex child reordering
- Add SelectPanel alpha component
- Trap focus in AnchoredOverlay as soon as it opens
- Improved performance for lists in layered components
- ActionList Fixes
- AnchoredOverlay and ActionList fixes for SelectPanel
Reviewed 30 pull requests in 2 repositories
primer/components 29 pull requests
- Handle on outside clicks in reverse order for overlay
- chore: Run 'npm audit fix' (/docs)
- fix: Hide intra-'Item' dividers on ':hover' and ':focus'
- Release Tracking
- feat: Skip canary deploys for Dependabot PRs
- fix(focusTrap): prevent blur if trap container is not in DOM
- fix(ActionList): description font size and truncation
- feat: Check lib & docs deps with Dependabot
- chore: Run 'npm audit fix' (/)
- chore: Replace 'yarn' with 'npm'
- Dialog Focus Fix
- Fix Check Spacing on selected items
- Add SelectPanel alpha component
-
refactor(focusZone): remove
currentFocusedIndex - Action Menu correctly fires onAction callback after close
- feat: ActionList.Item dividers
- Release Tracking
- Improved performance for lists in layered components
- ActionList Fixes
- renderMenuItem in ActionMenu checks preventDefault onClose
- onMouseDown passthrough in ActionMenu and AnchoredOverlay
- preventDefault on AnchoredOverlay instead of stopping propagation
- AnchoredOverlay and ActionList fixes for SelectPanel
- stopPropagation for mousedown in AnchoredOverlay based components
- Remove useMouseIntent in favor of focus-visible
- Some pull request reviews not shown.
dgreif/ring 1 pull request
Created an issue in primer/components that received 3 comments
Activate focus trap when clicking inside AnchoredOverlay
Describe the bug
AnchoredOverlay currently only activates the internal focus trap if the user interacts with the anchor element in specific ways. N…
3
comments
Opened 2 other issues in 1 repository
primer/components
2
open
Answered 3 discussions in 1 repository
31
contributions
in private repositories
May 3 – May 27