Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move sub layer creation into init in RandomFeatureGaussianProcess #10117

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

@Ghostvv
Copy link

@Ghostvv Ghostvv commented Jul 7, 2021

Description

when sub layers are created in self.build with subsequent build call, the names of the weights of sublayers get the name of the main layer which prevents keras saving in h5 format. Fix it by moving layer creation into init, then they will be built when they are called.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Tests

no functionality was added or changed, so old test should be enough

Test Configuration:

Checklist

@saberkun
Copy link
Member

@saberkun saberkun commented Jul 29, 2021

Hi, I think there were other issues if we don't build layers. @jereliu

Could we use the savedmodel format to save the keras model? It is the default and recommended path to save.

@Ghostvv
Copy link
Author

@Ghostvv Ghostvv commented Aug 10, 2021

i cannot do that, since crf from tf addons don't support savedmodel format

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants