move sub layer creation into init in RandomFeatureGaussianProcess #10117
Conversation
|
Hi, I think there were other issues if we don't build layers. @jereliu Could we use the savedmodel format to save the keras model? It is the default and recommended path to save. |
|
i cannot do that, since |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Description
when sub layers are created in
self.buildwith subsequentbuildcall, the names of the weights of sublayers get the name of the main layer which prevents keras saving inh5format. Fix it by moving layer creation into init, then they will be built when they are called.Type of change
Tests
no functionality was added or changed, so old test should be enough
Test Configuration:
Checklist
The text was updated successfully, but these errors were encountered: