peppy
Follow
peppy
Follow
Pinned
11,544 contributions in the last year
Less
More
Activity overview
Contribution activity
July 2021
Created 493 commits in 13 repositories
Created a pull request in ppy/osu-framework that received 21 comments
Refactor PopoverContainer to simplify dismissal process
This is intended to simplify how the dismissal of popovers works, removing the required logic inside CreateBody()'s resultant container. Passes all…
+142
−106
•
21
comments
Opened 84 other pull requests in 6 repositories
ppy/osu
59
merged
2
open
1
closed
- Fix beatmap search requests double-escaping
-
Update
LocalisationAnalyserand other packages - Fix inability to join a multiplayer room which has no password
- Fix authentication loss not handled correctly
- Output startup component load start/end times to non-debug logs
- Fix song select background not showing in multiplayer/playlists
- Fix derived API request types firing success when they shouldn't
- Fix mod display overflowing on contracted results panels
-
Tidy up
ModDisplay - Make "Blinds" and "Barrel Roll" mods incompatible
- Add the ability to enter and exit the skin editor via on-screen buttons
-
Fix
OnlinePlayScreensub-screens not loaded asynchronously -
Ensure online play subscreen is loaded before forwarding
OnExiting - Avoid showing time of play on results screen when autoplay
- Fix API request potentially firing failed events after completion
- Fix replay dates being unexpectedly updated on play completion
- Create a deep clone of score for score submission purposes
- Set score's rank on a failed submission
- Fix osu!(lazer) overwriting osu!(stable) desktop icons by adding back a suffix
- Fix editor composer allowing object placement without timing present
- Show warning on screens which require a current match to be selected
- Allow the schedule screen to show even when a current match is not selected
- Fix progression lines getting stuck after removing a match in ladder editor screen
- Add localisation coverage for remaining input settings
-
Fix multiple issues with
BeatSyncedContainer - Some pull requests not shown.
ppy/osu-framework
1
open
9
merged
1
closed
- Update SDL libraries with native library bump
- Update SDL2 package (and various other packages)
-
Add more testing of
ScreenStack - Fix refresh rate potentially being incorrect on startup
-
Throw an exception if a popover is attempted to be shown without a parent
PopoverContainer - Avoid creating a second popover when one is already displayed for the current target
- Remove obsoleted test browser lookup logic
- Obsolete ability for slider bar to handle keyboard input when not hovered
- Avoid collection-modified exceptions during unbind process
-
Remove bindable
StateandSchedulerrequirements ofVideoDecoder -
Fix deadlock state if an exception is thrown during
GameHost.Run()
ppy/osu-server-spectator
4
merged
ppy/osu-web
3
merged
ppy/osu-queue-score-statistics
1
open
1
merged
ppy/osu-resources
2
merged
Reviewed 158 pull requests in 9 repositories
ppy/osu 89 pull requests
- Fix ruleset icons overflowing from settings footer
- Apply combo offsets "colour hax" only on beatmap skins
- Fix room password not being percent-encoded in join request
- Add initial implementation of juice stream placement
-
Guard against
IndexOutOfRangeExceptionwhen parsing launch arguments - Implement "reverse pattern" in catch editor
- Fix relax mod still holding key after beatmap ends
- Make timeline blueprints outside of TimelineBlueprint boundaries interactable
- Add new 'soft' select sound variant and use it in some places
- Move and merge Overlays.KeyBinding into Overlays.Settings.Sections.Input
- Truncate beatmap text in playlist item
- Add initial implementation of juice stream path editing
- Implement horizontal flipping of hit objects in catch editor
- Make blinds move correctly when barrel roll mod is active
- Allow specifying different value of scaling and flipping support for a selection box
-
Move
CatcherfromCatcherAreatoCatchPlayfield -
Adapt to framework
PlatformActiontype change - Fix beatmap listing continually paginating when no more beatmaps are available
- Allow running with different game IDs for debug builds of osu!lazer
- Adjust user beatmap section naming on profile overlay to match web
- Allow confirming room password by pressing Enter
- Fix API request potentially firing failed events after completion
- Add the ability to enter and exit the skin editor via on-screen buttons
- Refactor combo colours retrieval to use skin config lookups instead
-
Ensure online play subscreen is loaded before forwarding
OnExiting - Some pull request reviews not shown.
ppy/osu-framework 33 pull requests
-
Allow adding query string params to non-GET
WebRequests - Fix GET request params not being percent-encoded
-
Flatten
PlatformActionstruct to an enum - Fix DrawableTrack/DrawableSample not receiving new parent adjustments when parent changes
- Make WeakList<T> enumerator not force nullability
-
Add more testing of
ScreenStack -
Clarify to use
ScreenStack.Pushon null stack exception from extension - Fix textbox readonly flag not working in all cases
-
Remove unused
object senderin ITextInputSource - Add Touchpad support for Windows 8+ and MacOS
-
Add ability to change case of a
LocalisableString - Minor optimization and cleanup for extension methods
- Remove speculative macOS crash fix
- Switch audio subsystem to use BassMix
- Fix popovers fading out in wrong location
- Dismiss popovers on pressing Escape
-
Refactor
PopoverContainerto simplify dismissal process - Make Bindable.UnbindFrom() virtual and called in all cases
- Remove extremely unsafe Bindable.Unbind() method
- Reset a StepSlider to its default value when right-clicked
- Allow drawables to manually show and hide popovers
- Improve usability of popover & popover container
-
Throw when attempting to set container to
Childrenand similar cases - Disable explicit enabling of logs overlay during dynamic compilation failure
- Use FrameworkFont in visual test interfaces
- Some pull request reviews not shown.
ppy/osu-web 12 pull requests
- Use country flags from twemoji project
- Fix octane watch sometimes not reloading
- Fix (lazer) failed plays showing up in profile recent plays
- Add settings and incompatibility rules for osu! target mod
- Allow user registration by default
- Fix audio player playlist for non-album listing
- Update php coding standard lint
- Implement New Difficulty Rating Colour Proposal
- Filter out fail scores by the pass flag instead of rank
- Add active user indicator in multiplayer rooms high table
- Accept legacy "m" parameter for beatmap redirect mode
- Adjust approach rate mod exclusivities
ppy/osu-wiki 11 pull requests
- Add Redside FA news post
- Add Aoi FA news post
-
[FR/EN] Add
Client, update the EN file - Add Rish FA news post
-
Convert
/beatmaps/links to/beatmapsets/ -
Update
Beatmap descriptionarticle to be more accurate and remove theexplicit lyricssection -
Update the
Developerslisting - Add ABSOLUTE CASTAWAY FA news post
-
Unify the style of
Legalwikilinks - Add wotoha FA news post
-
Fix wrong link being used in
Kiai Timearticle
ppy/osu-server-spectator 4 pull requests
ppy/osu-localisation-analyser 4 pull requests
ppy/osu-performance 3 pull requests
ppy/SDL2-CS 1 pull request
ppy/osu-resources 1 pull request
Created an issue in ppy/osu that received 2 comments
No response from server causes client to get stuck connected but unwilling to reconnect
Breakpoint in osu.Server.Spectator in a database method (ie retrieveRoom)
Attempt to create a room from osu! client
After it fails the client does…
2
comments
Opened 13 other issues in 3 repositories
ppy/osu
5
open
4
closed
- API exception handling needs major attention
- Banana shower placement should act more like a drag operation
- Improve visual cues on easy mod fail-save
- Null reference on attempting to create room after first attempt failed
- Losing connection to multiplayer server doesn't exit properly
- Custom rulesets should not attempt to submit scores
- Investigate switching tests to use in-memory realm
-
SkinProvidingContaineris very bad code quality - Import songs sorted with stable's "Date Added" sort
ppy/osu-web
2
open
Answered 12 discussions in 1 repository
ppy/osu
ppy/osu
- add the option to create a dedicated hit/keysounding difficulty in the editor
- Make multiplayer room passwords enterable
- Could we please have an updated Linux repository for osu!lazer?
- Could we please have an updated Linux repository for osu!lazer?
- osu!lazer tournament client not working for certain features
- The ability to scroll the timeline (editor) at a fixed speed, not current bpm
- Improving on the quality of images/videos/audio of old beatmaps
- Custom ruleset score servers
- Scratch sound when selecting new song
- disable annoying "failed to submit score" message on custom rulesets?
- Interface navigation accessibility
- Import songs sorted with stable's "Date Added" sort
18
contributions
in private repositories
Jul 3 – Jul 25