Permalink
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
[Build] Fix Antlr Shadowing and add Integration Tests (#2428)
* Reverts Antlr Shadowing and adds Integration Test to Check Proper Shading Previously we had no test suites which checked if the Spark3Runtime jar was actually usable with Spark3 builds. To check that the shadowJar is doing the right thing we add a new integration test which runs using only Spark3 and the ShadowJar. Only a few tests are included to prove that the jar is stable while we still rely on our unit tests for the majority of test coverage. * Shades Antlr Runtime This reintroduces the shading of Antlr along with a set of integration tests to verify that it is correctly shaded and working as expected. To accomplish this we copy several utility classes from Apache Spark so we can break our dependency on Spark Internal's accessing Antlr classes.
- Loading branch information
Showing
with
330 additions
and 16 deletions.
- +1 −1 .github/workflows/java-ci.yml
- +32 −1 build.gradle
- +105 −10 .../main/scala/org/apache/spark/sql/catalyst/parser/extensions/IcebergSparkSqlExtensionsParser.scala
- +30 −3 ...c/main/scala/org/apache/spark/sql/catalyst/parser/extensions/IcebergSqlExtensionsAstBuilder.scala
- +2 −1 spark3-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestCallStatementParser.java
- +160 −0 spark3-runtime/src/integration/java/org/apache/iceberg/spark/SmokeTest.java
Oops, something went wrong.