Highlights
- Pro
Pinned
4,142 contributions in the last year
Less
More
Activity overview
Contributed to
Shopify/theme-check,
Shopify/shopify-cli,
Shopify/homebrew-shopify
and 5 other
repositories
Contribution activity
August 2021
Created 2 commits in 1 repository
Created a pull request in Shopify/shopify-cli that received 1 comment
Fix uploading of binary theme files under Windows
WHY are these changes introduced? Binary files where not opened in binary mode when read. This broke encoding under Windows. But worked fine under…
+32
−4
•
1
comment
Opened 1 other pull request in 1 repository
Shopify/theme-check
1
merged
Reviewed 16 pull requests in 3 repositories
Shopify/theme-check
12 pull requests
- Add --output json option
- Switch to nokogiri 1.12, since it includes html5 support directly now
-
Autocorrection
MissingRequiredTemplateFiles -
Autocorrection
MissingTemplate -
Autocorrection
RequiredDirectories - Fixup documentation on undefined_object
- Correctly highlight substrings inside nodes
-
Autocorrection
DefaultLocale - Fix newline in outside_of_strings
- Alternating quotes inside HTML attributes
-
Autocorrection
UnusedAssign - Handle escaped file URIs in language server
Shopify/shopify-cli
3 pull requests
Shopify/liquid-c
1 pull request
4
contributions
in private repositories
Aug 9
