Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/4171 depd #4174

Open
wants to merge 5 commits into
base: 4.18
from
Open

Conversation

@UlisesGascon
Copy link
Member

@UlisesGascon UlisesGascon commented Feb 5, 2020

Main Changes

  • Upgrade to cookie-signature@1.1.0
  • Upgrade to setprototypeof@1.2.0
  • Upgrade to depd@2.0.0
  • Upgrade History.md as unreleased

Context

Changelog

UlisesGascon added 4 commits Feb 5, 2020
Related #4171
Related #4171
Related #4171
Related #4171
@UlisesGascon UlisesGascon requested a review from dougwilson Feb 5, 2020
History.md Show resolved Hide resolved
@@ -33,9 +33,9 @@
"content-disposition": "0.5.3",
"content-type": "~1.0.4",
"cookie": "0.4.0",
"cookie-signature": "1.0.6",
"cookie-signature": "1.1.0",

This comment has been minimized.

@dougwilson

dougwilson Feb 5, 2020
Member

This will create a confusing warning for users that says cookie-signature@1.1.0: wanted: {"node":">=6.6.0"} (current: {"node":"1.8.4","npm":"2.9.0"}) but will also fail to install Express when they have strict engine set.

This comment has been minimized.

@UlisesGascon

UlisesGascon Feb 5, 2020
Author Member

Do you want me to remove the bump for cookie-signature, @dougwilson ? 🤔

This comment has been minimized.

@dougwilson

dougwilson Feb 5, 2020
Member

Yea, it will likely need to be held for 5.0

Typo
Suggest by @dougwilson at #4174
"debug": "2.6.9",
"depd": "~1.1.2",
"depd": "~2.0.0",

This comment has been minimized.

@dougwilson

dougwilson Feb 5, 2020
Member

We want to make sure this doesn't cause duplicate depd stances within the install tree. I haven't checked if any of our other sub deps use depd, but you'll want to check that out, and then "bubble up" the dependency updated into this repo so we keep our install tree small.

This comment has been minimized.

@UlisesGascon

UlisesGascon Feb 5, 2020
Author Member

😅 Yes! You are right. Let's move it for 5.0

├─┬ cookie-session@1.3.3
│ ├─┬ cookies@0.7.3
│ │ ├── depd@1.1.2
├─┬ multiparty@4.2.1
│ ├─┬ fd-slicer@1.1.0
│ │ └── pend@1.2.0
│ ├─┬ http-errors@1.7.3
│ │ ├── depd@1.1.2
├─┬ send@0.17.1
│ ├── depd@1.1.2
│ ├── destroy@1.0.4
@@ -52,7 +52,7 @@
"safe-buffer": "5.1.2",
"send": "0.17.1",
"serve-static": "1.14.1",
"setprototypeof": "1.1.1",
"setprototypeof": "1.2.0",

This comment has been minimized.

@dougwilson

dougwilson Feb 5, 2020
Member

I think this is already in #4011

This comment has been minimized.

@UlisesGascon

UlisesGascon Feb 5, 2020
Author Member

Yes! Seems duplicated. Do you want me to revert it?

This comment has been minimized.

@dougwilson

dougwilson Feb 5, 2020
Member

We may want to so as I begin landing these once the plan is determined it doesn't delay with merge conflicts.

@dougwilson dougwilson added the deps label Feb 5, 2020
@dougwilson

This comment has been minimized.

Copy link

@dougwilson dougwilson commented on 3e7c7ab Feb 5, 2020

Please edit the commit message to remove the at mention for me. Unfortunately from past experience if this gets merged it will end up pinging me a lot as people fork express... :(

@UlisesGascon
Copy link
Member Author

@UlisesGascon UlisesGascon commented Feb 5, 2020

If you agree I will close the PR as setprototypeof is duplicated #4011, depd and cookie-signature are moved to 5.0.

@dougwilson
Copy link
Member

@dougwilson dougwilson commented Feb 8, 2020

Sure, though I didn't see a reason for the depd move (though I'm not going to say otherwise), but just wanted to clarify in case you thought maybe I said to move that one to 5.0.

@dougwilson dougwilson added the pr label Mar 10, 2020
@dougwilson dougwilson added this to the 4.18 milestone Apr 23, 2020
@dougwilson
Copy link
Member

@dougwilson dougwilson commented Apr 23, 2020

I have been working to snake the depd update through all the sub dependencies in play here so we can land an eval-free depd in our (maybe last) 4.x release.

@dougwilson dougwilson changed the base branch from master to 4.18 May 11, 2020
@dougwilson dougwilson mentioned this pull request May 20, 2020
3 of 11 tasks complete
@dougwilson
Copy link
Member

@dougwilson dougwilson commented Jun 3, 2020

Ok, just as an update I am on the last major module that needs the update: http-errors. It will bump the major of that module, but I made sure that it would not affect the major version of anything within express depending on it so it will actually work out 🎉 . I am planning to have this all completed this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.