jmagman
Follow
jmagman
Follow
Pinned
2,293 contributions in the last year
Less
More
Contribution activity
August 2021
Created 27 commits in 4 repositories
Created 1 repository
- jmagman/samples Dart
Created a pull request in flutter/flutter that received 13 comments
Migrate dds.dart to null safety
#88015 was reverted due to dart-lang/sdk#46934. Re-migrate dds.dart. Add a unit test to check the host port is 0 when unspecified. Part of #71511
+79
−37
•
13
comments
Opened 26 other pull requests in 4 repositories
flutter/flutter
2
open
16
merged
1
closed
- Changed tool cached properties to late finals
- Migrate fuchsia sdk and dependencies to null safety
- Migrate ios_deploy to null safety
- Migrate some flutter_tools tests to null safety
- Migrate mac.dart to null safety
- Do not try to codesign during plugin_test_ios
- Mark module_test_ios unflaky
- Verbosify and print every command in ios_content_validation_test
- Shuffle the tool_integration_tests within each shard
- Run plugin_lint_mac task when either flutter_tools or integration_test packages change
- Revert "Android Q transition by default"
- Rename IOSDeviceInterface to IOSDeviceConnectionInterface
- Make doctor Xcode version requirement clearer
- Support flutter create --platform singular flag
- Update flutter create templates for Xcode 13
- Refactor iOS integration_test API to support Swift, dynamically add native tests
- Wait for module UI test buttons to be hittable before tapping them
- Add Cupterino button animation test
- Fix Cuptertino dialog test to check correct fade transition
flutter/engine
4
merged
flutter/website
2
merged
flutter/samples
1
open
Reviewed 45 pull requests in 6 repositories
flutter/flutter
30 pull requests
- Migrate fuchsia sdk and dependencies to null safety
- Migrate mac.dart to null safety
- Add pageDelay to fullscreen_textfield_perf_test
- [flutter_conductor] Push correct revision to mirror remote from conductor
- [flutter_releases] Flutter beta 2.5.0-5.2.pre Framework Cherrypicks
- [flutter_tools] flutter update-packages --force-upgrade
- Migrate dds.dart to null safety
- [tools] Fix Android Studio duplicate detection
- Revert "Refactor iOS integration_test API to support Swift, dynamically add native tests"
- [tools] Add Xcode version to non-verbose Flutter doctor
- Revert "feat: migrate base/dds.dart to null-safety"
- Refactor iOS integration_test API to support Swift, dynamically add native tests
- Rename IOSDeviceInterface to IOSDeviceConnectionInterface
- [flutter_tool] Fix DesktopLogReader to capture all output
- Update flutter create templates for Xcode 13
- feat: migrate fuchsia/application_package.dart to null-safe
- refactor IosProject and MacOSProject to extends XcodeBasedProject to share common
- feat: migrate windows/application_package.dart to null-safety
- Make no-response plugin no-op for forks.
- feat: migrate base/dds.dart to null-safety
- feat: migrate macos/application_package.dart to null-safety
- [tools] fix Android Studio duplicate detection when installed via Jetbrains Toolbox
- fix: fix BuildableMacOSApp pass no projectBundleId to super error
- Add native iOS screenshots to integration_test
-
🔋 Enhance cupertino button fade in and fade out - Some pull request reviews not shown.
flutter/plugins
6 pull requests
- Eliminate build_all_plugins_app.sh
- [google_maps_flutter] Temporarily disable googleMapsPluginIsAdded
- [image_picker] Check for failure in iOS metadata updates
- Don't use 'flutter upgrade' on Cirrus
- [google_sign_in] Mark iOS arm64 simulators as unsupported
- [google_maps_flutter] Mark iOS arm64 simulators as unsupported
flutter/engine
5 pull requests
flutter/cocoon
2 pull requests
flutter/samples
1 pull request
flutter/packages
1 pull request
Created an issue in flutter/flutter that received 14 comments
Lock threads GitHub action should not run on forks
It's running and failing on my fork: https://github.com/jmagman/flutter/actions/runs/1092894209 Introduced in #81528
14
comments
Opened 14 other issues in 3 repositories
flutter/flutter
9
open
3
closed
-
First build of flutter_tool warns "The top level
pubcommand is deprecated. Usedart pubinstead." - Remove ARM simulator add-to-app caveat documentation
- PR title is missing from commit message when automerged
- "flutter run --profile" for iOS doesn't show "d" detach key command help text
- iOS apps crashing, -[SemanticsObject accessibilityAttributedLabel], objc_msgSend() selector name: length
- Tool test "overall_experience_test" failed on a framework-only PR change
- "flutter error messages include a DevTools link" tool test fails
- Migrate from Google Sign-In JavaScript Platform Library to Google Identity Services
- Support "flutter create --platform" singular option alias
- Test integration_test from native side during presubmit
- Engine iOS unit tests do not run on a real device
- Add Mac M1 ARM machines to the prod pool