Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn on unicode for FATFS #5171

Merged
merged 6 commits into from Aug 21, 2021
Merged

Turn on unicode for FATFS #5171

merged 6 commits into from Aug 21, 2021

Conversation

Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
@tannewt
Copy link
Member

@tannewt tannewt commented Aug 18, 2021

This also tweaks the repr for unicode strings to only escape a few
utf-8 code points. This makes emoji show in os.listdir() for
example.

Also, enable exfat support on full builds.

Fixes #5146

This also tweaks the repr for unicode strings to only escape a few
utf-8 code points. This makes emoji show in os.listdir() for
example.

Also, enable exfat support on full builds.

Fixes micropython#5146
@tannewt tannewt requested a review from jepler Aug 18, 2021
@tannewt tannewt added this to the 7.0.0 milestone Aug 18, 2021
Copy link
Member

@jepler jepler left a comment

Thanks! Looks good, much simpler than I worried it would be!

Loading

lib/oofatfs/ff.c Show resolved Hide resolved
Loading
Also, ignore more pins on SAMD boards and disable EXFAT on others.
Copy link
Collaborator

@dhalbert dhalbert left a comment

LGTM, and we can do more about the error messages issue in another PR

Loading

@dhalbert dhalbert merged commit 57841dc into adafruit:main Aug 21, 2021
231 checks passed
Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment