Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Two tweaks to BLE workflow #5217

Merged
merged 1 commit into from Aug 26, 2021
Merged

Two tweaks to BLE workflow #5217

merged 1 commit into from Aug 26, 2021

Conversation

Reviewers

@dhalbert dhalbert

Assignees
No one assigned
Labels
ble enhancement
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Add recursive delete
2 participants
@tannewt @dhalbert
@tannewt
Copy link
Member

@tannewt tannewt commented Aug 24, 2021

  1. Use autoreload for restarting after a write. This gives time for
    a follow up command before restarting BLE.
  2. Switch to recursive deletion of directories. This greatly
    simplifies deleting directories with contents.

Fixes adafruit/Adafruit_CircuitPython_BLE_File_Transfer#7
@tannewt
Two tweaks to BLE workflow
a5f2f6e 
1. Use autoreload for restarting after a write. This gives time for
   a follow up command before restarting BLE.
2. Switch to recursive deletion of directories. This greatly
   simplifies deleting directories with contents.

Fixes adafruit/Adafruit_CircuitPython_BLE_File_Transfer#7
@tannewt tannewt requested a review from dhalbert Aug 25, 2021
dhalbert
dhalbert approved these changes Aug 26, 2021
View changes
Copy link
Collaborator

@dhalbert dhalbert left a comment

This looks good to me, especially being careful who is doing the suspend/resume.

Loading

@dhalbert dhalbert merged commit fa63a41 into adafruit:main Aug 26, 2021
230 checks passed
Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment