Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gc.c: Ensure a gap of one byte before the finaliser table. #5245

Merged
merged 3 commits into from Aug 27, 2021
Merged

gc.c: Ensure a gap of one byte before the finaliser table. #5245

merged 3 commits into from Aug 27, 2021

Conversation

Reviewers

@tannewt tannewt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

MagTag Vaccination tracker crash in magtag.network.connect() between 7alpha3 and 7alpha4
2 participants
@jepler @tannewt
@jepler
Copy link
Member

@jepler jepler commented Aug 27, 2021 •
edited
Loading

.. or, for !MICROPY_ENABLE_FINALISER, before the first block of the pool.

Closes: #5021
Closes: micropython#7116

I tested this with a version of micropython#7716 (comment) and there were no problems detected. I haven't tested it on our real HW yet. I verified this fixes the original problem on magtag.

This is the same as micropython#7722 but prepared for merging into CircuitPython.
jepler added 3 commits Aug 27, 2021
@jepler
gc.c: Avoid valgrind false positives.
15133cb 
When you wish to use the valgrind memory analysis tool on micropython,
you can arrange to define MICROPY_DEBUG_VALGRIND to enable use of
special valgrind macros. For now, this only fixes `gc_get_ptr`
so that it never emits the diagnostic "Conditional jump or move depends
on uninitialised value(s)".

Signed-off-by: Jeff Epler <jepler@gmail.com>
@jepler
gc.c: Ensure a gap of one byte before the finaliser table.
5a162eb 
.. or, for !MICROPY_ENABLE_FINALISER, before the first block of the pool.

Closes: adafruit#5021
Closes: micropython#7116
Signed-off-by: Jeff Epler <jepler@gmail.com>
@jepler
Merge remote-tracking branch 'origin/main' into pool-fix-circuitpython
955c027
@dhalbert dhalbert requested a review from tannewt Aug 27, 2021
tannewt
tannewt approved these changes Aug 27, 2021
View changes
Copy link
Member

@tannewt tannewt left a comment

Thanks!

Loading

@tannewt tannewt merged commit 31b9dd4 into adafruit:main Aug 27, 2021
233 checks passed
Loading
@anecdata anecdata mentioned this pull request Sep 8, 2021
Closed
@tannewt tannewt mentioned this pull request Sep 14, 2021
Merged
dhalbert pushed a commit that referenced this issue Sep 15, 2021
@tannewt
Clear the buffer byte between ATB and FTB
e544909 
This ensures it has a known start state. An unknown state risks it
looking like a tail block similar to the problem fixed by #5245.

Fixes #5305
@jepler jepler deleted the pool-fix-circuitpython branch Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment