Skip to content

/ buildmaster-config

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not send "buildbot went away" emails to the buildbot-status maling list #162

Open
pablogsal opened this issue Jan 25, 2020 · 2 comments
Open

Do not send "buildbot went away" emails to the buildbot-status maling list #162

pablogsal opened this issue Jan 25, 2020 · 2 comments

Comments

@pablogsal
Copy link
Member

@pablogsal pablogsal commented Jan 25, 2020

@ned-deily requested that the "buildbot went away" emails are not sent to the buildbot-status mailing list. Any objections?

CC: @vstinner @zware
@vstinner
Copy link
Member

@vstinner vstinner commented Jan 26, 2020

I don't see the point of these emails. Please stop to send them :-)
@zware
Copy link
Member

@zware zware commented Jan 27, 2020

They're supposed to only be sent when a worker suddenly disappears, not every time the master is restarted (and restarts have become rather more frequent of late :)). I've pinged buildbot/buildbot#4234 about it, but if there's no change then we might as well disable them to the list:

buildmaster-config/master/custom/workers.py

Line 31 in f4ae6ba

map(str, filter(None, (settings.get("status_email", None), owner_email)))

Removing settings.get("status_email", None) here would do it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
@vstinner @zware @pablogsal
You can’t perform that action at this time.