Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upLiveTV support (both DVR and free Plex streaming/IPTV) - Requesting code review #543
Conversation
Catch-up
| self.items = self.findItems(data) | ||
|
|
||
|
|
||
| @utils.registerPlexObject |
Hellowlol
Aug 9, 2020
Collaborator
Your using the decorator so the object can be built. Have you checked that this dont conflict with other xml object that uses the same tag (so the correct class is built)
Your using the decorator so the object can be built. Have you checked that this dont conflict with other xml object that uses the same tag (so the correct class is built)
| @@ -32,6 +33,8 @@ def _loadData(self, data): | |||
| """ Load attribute values from Plex XML response. """ | |||
| self._data = data | |||
| self.listType = 'video' | |||
| self.guid = data.attrib.get('guid') | |||
Hellowlol
Aug 9, 2020
Collaborator
Im not sold on the changed to the video class. This is getting reusing many places. Would it be better for subclass used own class for live tv/recordings) ? Im not sure.
Im not sold on the changed to the video class. This is getting reusing many places. Would it be better for subclass used own class for live tv/recordings) ? Im not sure.
|
Nice work. Livetv etc support has been non existent because no contributer have used it. :) |
|
Thanks for the feedback. I will make the necessary changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
First time working with XML data. Seems rather straightforward once I understood how you handled parsing.
Have not written test files yet, waiting for feedback if you could give any.