Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow up to 100 CI checks for CI status command #2704

Merged
merged 1 commit into from Apr 4, 2022

Conversation

Copy link
Contributor

@rjmunro rjmunro commented Feb 1, 2021

I'm working on a project that has a complex CI setup, and uses more than 30 CI jobs. Sometimes hub ci-status would report success when it was still pending, which was very annoying, because it was only checking the first 30.

per_page=100 is used in many other queries, and is the maximum that is allowed without paging.

@rjmunro
Copy link
Author

@rjmunro rjmunro commented Feb 2, 2021

CI seems to be failing to on the hub fork command, possibly because the repo it is trying to fork has changed. It doesn't seem to be related to my change at all.

I'm working on a project that has a complex CI setup, and reaches more
than 30. Sometimes `hub ci-status` would report success when it was
still pending, which was very annoying.

per_page=100 is used in many other queries, and is the maximum that is
allowed without paging.
@rjmunro
Copy link
Author

@rjmunro rjmunro commented Mar 28, 2022

I've rebased and force pushed now that CI is working again.

Copy link
Member

@mislav mislav left a comment

Thank you! <3

@mislav mislav merged commit 363513a into github:master Apr 4, 2022
1 check passed
@rjmunro rjmunro deleted the increase-max-ci-statuses branch Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants