Skip to content
#

magento

Here are 1,933 public repositories matching this topic...

magento2
iba-1
iba-1 commented Oct 6, 2021

Summary (*)

When trying to get a list of categories, or even only one category, if "image" field is filled but the image can't be found on filesystem the request will fail with "Error: Category image not found."
This shouldn't be the correct behavior as not being able to render an image for a category isn't an unrecoverable error, and we've been able to handle in frontend this kind of errors

vue-storefront
Fifciu
Fifciu commented Jun 22, 2021

Currently, catch block is the same for both methods in useForgotPasswordFactory (https://github.com/vuestorefront/vue-storefront/pull/5971/files/0e001721be751b0b0130915023ea0867722e1065#diff-89077440c1264480ee6ffbbcfb08d6c64c9881bea61ebbd8e0e5d260085b66ad):

err.message = err?.graphQLErrors?.[0]?.message || err.message;

Let's create an external function that takes care of that a

React Storefront - PWA for eCommerce. 100% offline, platform agnostic, headless, Magento 2 supported. Always Open Source, Apache-2.0 license. Join us as contributor (contributors@reactstorefront.io).

  • Updated Sep 1, 2021
  • JavaScript
lukeromanowicz
lukeromanowicz commented Apr 20, 2019

Thanks to awesome work of @ResuBaka in #210 we now are able to use typescript. Even though JS still is and will be supported, we'd like to fully utilize benefits of this feature by rewriting the code with typings. Contributions with any VSF-API parts are welcome but please, group it by segments/directories (i.e. a full extension, whole API section, whole lib, full one platform, etc). PRs of single

Improve this page

Add a description, image, and links to the magento topic page so that developers can more easily learn about it.

Curate this topic

Add this topic to your repo

To associate your repository with the magento topic, visit your repo's landing page and select "manage topics."

Learn more