Form Binding logic is extremely inefficient #243

davidfowl · 2020-03-14T23:21:12Z

Bytes -> Dictionary -> Another Dictionary -> JSON string -> Object

Carter/src/Carter/Modelbinding/BindExtensions.cs

Lines 39 to 67 in 2dfc291

    
           if (request.HasFormContentType) 
        
           { 
        
               var res = request.Form.ToDictionary(key => key.Key, val => 
        
               { 
        
                   var type = typeof(T); 
        
                   var propertyType = type.GetProperty(val.Key)?.PropertyType; 
        
                   if (propertyType == null) 
        
                   { 
        
                       return null; 
        
                   } 
        
                   if (propertyType.IsArray() || propertyType.IsCollection() || propertyType.IsEnumerable()) 
        
                   { 
        
                       var colType = propertyType.GetElementType(); 
        
                       if (colType == null) 
        
                       { 
        
                           colType = propertyType.GetGenericArguments().First(); 
        
                       } 
        
                       return val.Value.Select(y => { return ConvertToType(y, colType); }); 
        
                   } 
        
                   return ConvertToType(val.Value[0], propertyType); 
        
               }); 
        
               var json = JsonSerializer.Serialize(res); 
        
               return JsonSerializer.Deserialize<T>(json); 
        
           }

jchannon · 2020-03-15T10:44:14Z

I knew this when first written and never gone back to look at it unfortunately

…

On Sat, 14 Mar 2020 at 23:21, David Fowler ***@***.***> wrote: Bytes -> Dictionary -> Another Dictionary -> JSON string -> Object https://github.com/CarterCommunity/Carter/blob/2dfc291a518d7d9e2febd78b203538e72ea9306e/src/Carter/Modelbinding/BindExtensions.cs#L39-L67 — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#243>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAZVJSUDL4IRVKSJJQJJJTRHQGPJANCNFSM4LJ6S6CA> .

davidfowl · 2020-03-15T15:59:35Z

It would be good to understand if people are using this feature of Carter. Especially if it’s mostly used for backend APIs maybe you can eventually kill the feature

jchannon · 2020-03-15T16:40:25Z

Yeah not entirely sure on usage numbers. Hard to calculate that. It was added as someone asked for it I think but would assume most is json bodies

…

On Sun, 15 Mar 2020 at 15:59, David Fowler ***@***.***> wrote: It would be good to understand if people are using this feature of Carter. Especially if it’s mostly used for backend APIs maybe you can eventually kill the feature — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#243 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAZVJW4HLCUSAON5T5BHBDRHT3PHANCNFSM4LJ6S6CA> .

CarterCommunity / Carter

Form Binding logic is extremely inefficient #243

Form Binding logic is extremely inefficient #243

davidfowl commented Mar 14, 2020

jchannon commented Mar 15, 2020

davidfowl commented Mar 15, 2020

jchannon commented Mar 15, 2020

CarterCommunity / Carter

Sponsor CarterCommunity/Carter

Join GitHub today

Form Binding logic is extremely inefficient #243

Form Binding logic is extremely inefficient #243

Comments

davidfowl commented Mar 14, 2020

jchannon commented Mar 15, 2020

davidfowl commented Mar 15, 2020

jchannon commented Mar 15, 2020