Skip to content
#

shopware

Star

Here are 304 public repositories matching this topic...

Language: All
Filter by language
All 304 PHP 192 JavaScript 27 Shell 14 HTML 11 Smarty 11 Twig 9 CSS 5 Dockerfile 4 TypeScript 4 Java 3
Sort: Best match
Sort options
Best match Most stars Fewest stars Most forks Fewest forks Recently updated Least recently updated
vue-storefront

vuestorefront / vue-storefront

Star
Open

Externalize catch part from useForgotPasswordFactory

Fifciu
Fifciu commented Jun 22, 2021

Currently, catch block is the same for both methods in useForgotPasswordFactory (https://github.com/vuestorefront/vue-storefront/pull/5971/files/0e001721be751b0b0130915023ea0867722e1065#diff-89077440c1264480ee6ffbbcfb08d6c64c9881bea61ebbd8e0e5d260085b66ad):

err.message = err?.graphQLErrors?.[0]?.message || err.message;

Let's create an external function that takes care of that a

Read more
good first issue 1: Easy Next commercetools
platform

shopware / platform

Star
Open

getCriteria in ProductStreamUpdater does not guard against empty array

5
Xarno
Xarno commented Oct 27, 2021

PHP Version

8.0.8

Shopware Version

6.4.5.1

Expected behaviour

Function getCriteria in ProductStream should not add an empty Array as Argument for EqualsAnyFilter.

Actual behaviour

It can add empty array. And that leads to broken searches, because then the Criteria will only lead to empty results.
Yes the shopware code itself does not look like it does that. But still … it's

Read more
Good first issue
Find more good first issues

Improve this page

Add a description, image, and links to the shopware topic page so that developers can more easily learn about it.

Curate this topic

Add this topic to your repo

To associate your repository with the shopware topic, visit your repo's landing page and select "manage topics."

Learn more