andrewbranch
Follow
andrewbranch
Follow
Pinned Loading
1,249 contributions in the last year
Less
More
Activity overview
Contributed to
microsoft/TypeScript,
DefinitelyTyped/DefinitelyTyped,
microsoft/DefinitelyTyped-tools
and 5 other
repositories
Loading
Contribution activity
November 2021
Created 5 commits in 3 repositories
Created a pull request in microsoft/TypeScript that received 9 comments
Revert changes to matchFiles/readDirectory made since 4.3
Reverts #44710, #46086, and #46673.
Fixes #46577.
I have discovered that ts.matchFiles/ts.sys.readDirectory does a lot of extremely confusing thin…
+20
−55
•
9
comments
Opened 3 other pull requests in 1 repository
microsoft/TypeScript
1
open
2
merged
Reviewed 25 pull requests in 5 repositories
microsoft/TypeScript
17 pull requests
-
use default type parameter rather than
unknownwhen show quick help - Revert changes to matchFiles/readDirectory made since 4.3
- Removed replacement from jsx completions
- enable go-to-type-definition on type nodes
- fix(46605): Template literal autocomplete not working for parameter objects
- Fix extra newline in class member snippet completions
- Sort resolved auto-import completions by number of directory separators
- fix(46666): No outlining span returned for multiline comment
- Make specifier generation from export map information conditional on module resolution mode
- Allow import assertions on esm imports under module: nodenext
- fix(46570) Unhelpful "Did you forget to include 'void' in your type argument to 'Promise'" in JS file
- Properly check whether union type contains only primitive types
- [release-4.5] Exclude identity relation from mapped type relation check
- fix(46512): JSX cannot use tag names that start with "public-"
- Exclude identity relation from mapped type relation check
- Duplicate GDPR fragment from VS Code repo
- Check for type parameters on original type when getting type argument completions
DefinitelyTyped/DefinitelyTyped
5 pull requests
microsoft/TypeScript-wiki
1 pull request
microsoft/DefinitelyTyped-tools
1 pull request
microsoft/TypeScript-Website
1 pull request
Created an issue in microsoft/TypeScript that received 1 comment
What is ts.sys.readDirectory even supposed to do?
Following up on #46673 (comment), I started a more thorough investigation of ts.matchFiles (which is just ts.sys.readDirectory without the system h…
1
comment
Opened 5 other issues in 1 repository
microsoft/TypeScript
5
open
- Excessive instantiation depth with fluent chaining API
- --module nodenext self-name references don't work with an outDir from clean build
-
Infer ESM-compatible
modulesetting for inferred projects in"type": "module"or.mjs/.mtsfiles -
Auto import sorting
path/posixandpath/win32abovepath - Give better error message when trying to import something declared as a global
Started 1 discussion in 1 repository
react-hook-form/react-hook-form
react-hook-form/react-hook-form
1
contribution
in private repositories
Nov 2