chore(release-vnext): Postpublish step to tag prereleases #20471

ling1726 · 2021-11-03T10:20:33Z

Pull request checklist

Addresses an existing issue: Fixes #0
Include a change request file using $ yarn change

Description of changes

Following #20352, all v9 packages will be released under tag latest,
adds a postpublish hook that will tag each of the released packages with
the appropriate prerelease version

Focus areas to test

(optional)

The text was updated successfully, but these errors were encountered:

Documentation changes are not code that is shipped with the published package, and should not pollute the changelog

Following microsoft#20352, all v9 packages will be released under tag `latest`, adds a postpublish hook that will tag each of the released packages with the appropriate prerelease version

size-auditor · 2021-11-03T10:36:07Z

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: fe9829e4818f9bb7206df37747d5da332706ae4b (build)

fabricteam · 2021-11-03T10:42:23Z

📊 Bundle size report

Unchanged fixtures

Package & Exports	Size (minified/GZIP)
`react-accordion` Accordion (including children components)	`57.542 kB` `18.214 kB`
`react-avatar` Avatar	`54.097 kB` `15.331 kB`
`react-badge` Badge	`22.394 kB` `6.707 kB`
`react-badge` CounterBadge	`24.773 kB` `7.387 kB`
`react-badge` PresenceBadge	`29.768 kB` `8.517 kB`
`react-button` Button	`24.651 kB` `7.462 kB`
`react-button` CompoundButton	`29.939 kB` `8.418 kB`
`react-button` MenuButton	`27.046 kB` `8.227 kB`
`react-button` SplitButton	`33.261 kB` `9.328 kB`
`react-button` ToggleButton	`33.78 kB` `8.065 kB`
`react-card` Card - All	`50.038 kB` `14.802 kB`
`react-card` Card	`45.458 kB` `13.574 kB`
`react-card` CardFooter	`7.418 kB` `3.182 kB`
`react-card` CardHeader	`8.778 kB` `3.64 kB`
`react-card` CardPreview	`7.682 kB` `3.341 kB`
`react-components` react-components: Accordion, Button, FluentProvider, Image, Menu, Popover	`169.304 kB` `48.469 kB`
`react-components` react-components: FluentProvider & webLightTheme	`32.54 kB` `10.63 kB`
`react-divider` Divider	`14.828 kB` `5.375 kB`
`react-image` Image	`9.041 kB` `3.734 kB`
`react-input` Input	`13.842 kB` `4.965 kB`
`react-label` Label	`8.177 kB` `3.445 kB`
`react-link` Link	`10.883 kB` `4.449 kB`
`react-make-styles` makeStaticStyles (runtime)	`7.59 kB` `3.322 kB`
`react-make-styles` makeStyles + mergeClasses (runtime)	`22.238 kB` `8.411 kB`
`react-make-styles` makeStyles + mergeClasses (build time)	`2.561 kB` `1.206 kB`
`react-menu` Menu (including children components)	`105.392 kB` `32.533 kB`
`react-menu` Menu (including selectable components)	`107.78 kB` `32.898 kB`
`react-popover` Popover	`101.092 kB` `30.67 kB`
`react-portal` Portal	`6.621 kB` `2.226 kB`
`react-positioning` usePopper	`22.808 kB` `7.935 kB`
`react-provider` FluentProvider	`14.056 kB` `5.267 kB`
`react-slider` RangedSlider	`39.807 kB` `11.491 kB`
`react-slider` Slider	`33.196 kB` `10.312 kB`
`react-switch` Switch	`25.311 kB` `8.143 kB`
`react-text` Text - Default	`10.603 kB` `4.172 kB`
`react-text` Text - Wrappers	`13.899 kB` `4.513 kB`
`react-theme` Teams: all themes	`29.264 kB` `6.487 kB`
`react-theme` Teams: Light theme	`18.391 kB` `5.225 kB`
`react-tooltip` Tooltip	`43.871 kB` `15.165 kB`
`react-utilities` SSRProvider	`189 B` `161 B`

_{🤖 This report was generated against fe9829e4818f9bb7206df37747d5da332706ae4b}

codesandbox · 2021-11-03T10:58:22Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 7b837da:

Sandbox	Source
@fluentui/react 8 starter	Configuration
@fluentui/react-components 9 starter	Configuration

fabricteam · 2021-11-03T11:17:51Z

Perf Analysis (`@fluentui/react`)

Scenario	Render type	Master Ticks	PR Ticks	Iterations	Status
Dialog	mount	2666	2699	1000	Possible regression

All results

Scenario	Render type	Master Ticks	PR Ticks	Iterations	Status
Avatar	mount	1030	968	5000
BaseButton	mount	998	1012	5000
Breadcrumb	mount	2631	2629	1000
ButtonNext	mount	566	579	5000
Checkbox	mount	1660	1658	5000
CheckboxBase	mount	1391	1422	5000
ChoiceGroup	mount	4995	5050	5000
ComboBox	mount	1002	1032	1000
CommandBar	mount	10280	10476	1000
ContextualMenu	mount	8562	8661	1000
DefaultButton	mount	1223	1230	5000
DetailsRow	mount	4073	3978	5000
DetailsRowFast	mount	4058	3997	5000
DetailsRowNoStyles	mount	3767	3919	5000
Dialog	mount	2666	2699	1000	Possible regression
DocumentCardTitle	mount	184	174	1000
Dropdown	mount	3395	3468	5000
FluentProviderNext	mount	3815	3900	5000
FluentProviderWithTheme	mount	223	227	10
FluentProviderWithTheme	virtual-rerender	100	96	10
FluentProviderWithTheme	virtual-rerender-with-unmount	243	268	10
FocusTrapZone	mount	1882	1809	5000
FocusZone	mount	1854	1800	5000
IconButton	mount	1875	1887	5000
Label	mount	405	372	5000
Layer	mount	3200	3156	5000
Link	mount	511	519	5000
MakeStyles	mount	1854	1812	50000
MenuButton	mount	1595	1681	5000
MessageBar	mount	1993	2084	5000
Nav	mount	3539	3467	1000
OverflowSet	mount	1157	1172	5000
Panel	mount	2575	2620	1000
Persona	mount	924	901	1000
Pivot	mount	1525	1557	1000
PrimaryButton	mount	1397	1393	5000
Rating	mount	8455	8442	5000
SearchBox	mount	1466	1525	5000
Shimmer	mount	2730	2813	5000
Slider	mount	2097	2113	5000
SpinButton	mount	5337	5524	5000
Spinner	mount	447	445	5000
SplitButton	mount	3307	3354	5000
Stack	mount	560	540	5000
StackWithIntrinsicChildren	mount	1933	1988	5000
StackWithTextChildren	mount	5377	5304	5000
SwatchColorPicker	mount	11074	11259	5000
TagPicker	mount	2792	2874	5000
TeachingBubble	mount	13391	13273	5000
Text	mount	460	454	5000
TextField	mount	1490	1449	5000
ThemeProvider	mount	1266	1251	5000
ThemeProvider	virtual-rerender	633	622	5000
ThemeProvider	virtual-rerender-with-unmount	2073	2083	5000
Toggle	mount	836	868	5000
buttonNative	mount	128	141	5000

Perf Analysis (`@fluentui/react-northstar`)

Perf tests with no regressions

Scenario	Current PR Ticks	Baseline Ticks	Ratio
ChatWithPopoverPerf.default	464	412	1.13:1
PortalMinimalPerf.default	183	164	1.12:1
ButtonMinimalPerf.default	206	187	1.1:1
ListWith60ListItems.default	725	660	1.1:1
HeaderMinimalPerf.default	415	381	1.09:1
TableMinimalPerf.default	462	426	1.08:1
TreeWith60ListItems.default	213	198	1.08:1
AccordionMinimalPerf.default	187	175	1.07:1
SegmentMinimalPerf.default	404	376	1.07:1
DropdownManyItemsPerf.default	790	742	1.06:1
SplitButtonMinimalPerf.default	4833	4558	1.06:1
AnimationMinimalPerf.default	440	421	1.05:1
GridMinimalPerf.default	373	354	1.05:1
LabelMinimalPerf.default	436	416	1.05:1
ButtonSlotsPerf.default	626	602	1.04:1
ChatMinimalPerf.default	740	714	1.04:1
EmbedMinimalPerf.default	4653	4492	1.04:1
HeaderSlotsPerf.default	833	800	1.04:1
LayoutMinimalPerf.default	401	385	1.04:1
ListMinimalPerf.default	563	542	1.04:1
RadioGroupMinimalPerf.default	497	479	1.04:1
StatusMinimalPerf.default	753	725	1.04:1
IconMinimalPerf.default	672	646	1.04:1
DividerMinimalPerf.default	405	395	1.03:1
FormMinimalPerf.default	455	441	1.03:1
ListCommonPerf.default	698	680	1.03:1
SkeletonMinimalPerf.default	403	392	1.03:1
ToolbarMinimalPerf.default	1026	998	1.03:1
TooltipMinimalPerf.default	1121	1093	1.03:1
AttachmentSlotsPerf.default	1171	1152	1.02:1
ButtonOverridesMissPerf.default	1893	1861	1.02:1
CardMinimalPerf.default	637	624	1.02:1
CheckboxMinimalPerf.default	3005	2946	1.02:1
DialogMinimalPerf.default	822	807	1.02:1
ItemLayoutMinimalPerf.default	1314	1292	1.02:1
MenuButtonMinimalPerf.default	1811	1781	1.02:1
ProviderMergeThemesPerf.default	1762	1722	1.02:1
RefMinimalPerf.default	242	237	1.02:1
TableManyItemsPerf.default	2103	2052	1.02:1
CustomToolbarPrototype.default	4357	4279	1.02:1
TreeMinimalPerf.default	871	856	1.02:1
VideoMinimalPerf.default	675	664	1.02:1
AttachmentMinimalPerf.default	173	171	1.01:1
CarouselMinimalPerf.default	512	509	1.01:1
DatepickerMinimalPerf.default	5793	5725	1.01:1
MenuMinimalPerf.default	937	931	1.01:1
SliderMinimalPerf.default	1795	1781	1.01:1
TextMinimalPerf.default	383	380	1.01:1
TextAreaMinimalPerf.default	571	568	1.01:1
ImageMinimalPerf.default	413	411	1:1
ProviderMinimalPerf.default	1227	1222	1:1
AvatarMinimalPerf.default	208	211	0.99:1
DropdownMinimalPerf.default	3321	3352	0.99:1
PopupMinimalPerf.default	621	626	0.99:1
LoaderMinimalPerf.default	728	745	0.98:1
RosterPerf.default	1342	1376	0.98:1
BoxMinimalPerf.default	365	376	0.97:1
FlexMinimalPerf.default	303	311	0.97:1
InputMinimalPerf.default	1354	1403	0.97:1
ListNestedPerf.default	596	615	0.97:1
AlertMinimalPerf.default	293	304	0.96:1
ReactionMinimalPerf.default	414	430	0.96:1
ChatDuplicateMessagesPerf.default	323	346	0.93:1

scripts/beachball/index.ts

ecraig12345 · 2021-11-03T17:39:32Z

scripts/beachball/index.ts

+      const tag = 'beta';
+      if (version.includes(tag) && process.env.RELEASE_VNEXT) {
+        console.log(`tagging ${name}@${version} with ${tag}`);
+        const res = await exec(`npm dist-tag add ${name}@${version} ${tag}`);


I wonder if it would be better to just spawnSync with stdio: inherit and check the exit code?

And regardless of specific exec/spawn method you should probably check the exit code instead of or in addition to stderr

in commit 7b837da I ended up manually promisifying and checking the status code of exec

I don't think the promise approach is really necessary (since this won't be done multi-threaded)? Not super important though.

…luentui into chore/tag-postpublish

varholak-peter

LGTM 🇩🇰

…0471)" This reverts commit d3e224c.

…0471)" (#20598) This reverts commit d3e224c.

ling1726 added 2 commits Nov 3, 2021

chore(react-components): Remove doc related changelog entries

251c50e

Documentation changes are not code that is shipped with the published package, and should not pollute the changelog

chore(release-vnext): Postpublish step to tag prereleases

1d6c3d0

Following microsoft#20352, all v9 packages will be released under tag `latest`, adds a postpublish hook that will tag each of the released packages with the appropriate prerelease version

ling1726 requested review from as code owners Nov 3, 2021

msft-fluent-ui-bot assigned khmakoto Nov 3, 2021

Merge remote-tracking branch 'origin/master' into chore/tag-postpublish

036d8ca

ling1726 removed request for Nov 3, 2021

add docstring

b650f61

varholak-peter self-assigned this Nov 3, 2021

varholak-peter reviewed Nov 3, 2021

View changes

scripts/beachball/index.ts Outdated Show resolved Hide resolved

Loading

scripts/beachball/index.ts Outdated Show resolved Hide resolved

Loading

ling1726 added 2 commits Nov 3, 2021

pr feedback

b93b382

use async, use npm token auth

65b4a7a

ecraig12345 reviewed Nov 3, 2021

View changes

ling1726 added 2 commits Nov 3, 2021

add codesandbox links

ba1c031

check status code

7b837da

ling1726 requested review from behowell and khmakoto as code owners Nov 3, 2021

ling1726 added 3 commits Nov 4, 2021

revert avatar changes

fe040f4

Merge branch 'master' into chore/tag-postpublish

9f936db

Merge branch 'chore/tag-postpublish' of https://github.com/ling1726/f…

a6ac29f

…luentui into chore/tag-postpublish

ling1726 removed request for behowell and khmakoto Nov 4, 2021

varholak-peter approved these changes Nov 4, 2021

View changes

ecraig12345 approved these changes Nov 4, 2021

View changes

use correct cwd

b7a18af

ling1726 merged commit d3e224c into microsoft:master Nov 12, 2021
19 of 20 checks passed

Loading

ling1726 added a commit that referenced this issue Nov 12, 2021

Revert "chore(release-vnext): Postpublish step to tag prereleases (#2…

6697c28

…0471)" This reverts commit d3e224c.

ling1726 mentioned this pull request Nov 12, 2021

Revert "chore(release-vnext): Postpublish step to tag prereleases" #20598

Merged

ling1726 added a commit that referenced this issue Nov 12, 2021

Revert "chore(release-vnext): Postpublish step to tag prereleases (#2…

75bcff6

…0471)" (#20598) This reverts commit d3e224c.

microsoft / fluentui Public

chore(release-vnext): Postpublish step to tag prereleases #20471

chore(release-vnext): Postpublish step to tag prereleases #20471

ling1726 commented Nov 3, 2021

size-auditor bot commented Nov 3, 2021 •

edited

Loading

fabricteam commented Nov 3, 2021 •

edited

Loading

codesandbox bot commented Nov 3, 2021 •

edited

Loading

fabricteam commented Nov 3, 2021 •

edited

Loading

ecraig12345 Nov 3, 2021

ecraig12345 Nov 3, 2021 •

edited

Loading

ling1726 Nov 3, 2021

ecraig12345 Nov 4, 2021

varholak-peter left a comment

microsoft / fluentui Public

chore(release-vnext): Postpublish step to tag prereleases #20471

chore(release-vnext): Postpublish step to tag prereleases #20471

Conversation

ling1726 commented Nov 3, 2021

Pull request checklist

Description of changes

Focus areas to test

size-auditor bot commented Nov 3, 2021 • edited Loading

Asset size changes

fabricteam commented Nov 3, 2021 • edited Loading

📊 Bundle size report

codesandbox bot commented Nov 3, 2021 • edited Loading

fabricteam commented Nov 3, 2021 • edited Loading

Perf Analysis (@fluentui/react)

Perf Analysis (@fluentui/react-northstar)

ecraig12345 Nov 3, 2021

Choose a reason for hiding this comment

ecraig12345 Nov 3, 2021 • edited Loading

Choose a reason for hiding this comment

ling1726 Nov 3, 2021

Choose a reason for hiding this comment

ecraig12345 Nov 4, 2021

Choose a reason for hiding this comment

varholak-peter left a comment

size-auditor bot commented Nov 3, 2021 •

edited

Loading

fabricteam commented Nov 3, 2021 •

edited

Loading

codesandbox bot commented Nov 3, 2021 •

edited

Loading

fabricteam commented Nov 3, 2021 •

edited

Loading

Perf Analysis (`@fluentui/react`)

Perf Analysis (`@fluentui/react-northstar`)

ecraig12345 Nov 3, 2021 •

edited

Loading