profiling

https://github.com/brendangregg/FlameGraph

Currently they are weirdly aligned:

We want something like this

Also double check they have the same size.

I think it would be cool to import the library part of tracy from vcpkg. They don't add packages themselves - they only accept if someone writes the pull request. Tracy was actually requested there a while ago.

Feel free to close this is this is unwanted.

There are many instances of INSTR_CREATE macro documentation saying things like this:

* \param dc  The void * dcontext used to allocate memory for the instr_t.

That should have a # to link up the instr_t type.

@kakkoyun correctly mentioned that it's possible that our understanding of what makes a record unique might change over time, so our keys for locations, functions and mappins should be verioned. Eg. these prefixes should contain a v1 versioned string somewhere:

https://github.com/parca-dev/parca/blob/c086e4d35270f1fd0903f93f0842f3d8737e7131/pkg/storage/metastore/kv.go#L22