Skip to content
#

design-system

Here are 1,140 public repositories matching this topic...

grommet
DaiQiangReal
DaiQiangReal commented Nov 8, 2021

Which Component 出现bug的组件

  • description

semi-ui version

  • latest

Expected result 期望的结果是什么

  • 需要支持 key 作为 label 使用时 可以传入 reactElement

Actual result 实际的结果是什么

  • 传入 reactElemet 时,key 仍被用作 reactKey 且被 toString 为 [object Object]

Steps to reproduce 复现步骤

![Xkn9JEjVxI](https://user-images.githubusercontent.com/29626873/140703334-caa29eb5-0083-4943-9963-e3

polaris-react
theme-ui
MuhammadJamaluddin
MuhammadJamaluddin commented Nov 15, 2021

Is your feature request related to a problem? Please describe.
I don't think Theme UI should be opinionated on which SVGs should be used for the Radio & CheckBox components

Describe the solution you'd like
Probably an additional prop called customIcon maybe... based on which we could conditionally render the passed SVG icon otherwise we use the default icons?

**Describe alter

eui
react
emplums
emplums commented Dec 2, 2020

(moved over from https://github.com/github/design-systems/issues/860, thanks @smockle 👋 !)

Problem

Occasionally it’s useful to add an interactive element with the semantics of button (correctly represented in the AT)—but without its visual styles.

Solution

Other teams at GitHub spread the following object in sx props to destyle Buttons:

// Removes most of 'button'’s visual appearanc

Improve this page

Add a description, image, and links to the design-system topic page so that developers can more easily learn about it.

Curate this topic

Add this topic to your repo

To associate your repository with the design-system topic, visit your repo's landing page and select "manage topics."

Learn more