stellar

The asset ordering in the /trades endpoint is not deterministic. See, for example how responses are different for the same request ( /trades?cursor=133053547049738241-0&limit=10&order=asc ) in https://horizon.stellar.org/ vs https://horizon-stg-pubnet.stellar.org/.

The ordering sho

Errors were reported while checking the availability of links.

📝 Summary
---------------------
🔍 Total..........429
✅ Successful.....295
⏳ Timeouts.........0
🔀 Redirected.......0
👻 Excluded.........0
⚠ Unknown..........0
🚫 Errors.........134

Errors in README.md
✗ https://github.com/KarthikNayak024 (HTTP status client error (429 Too Many Requests) for url (https://github.com/KarthikNayak024)

The current streaming example doesn't implement the onerror() callback. In production this means that the subscriber can loose connection without knowing about it.

The option dinitIceSheetHeight in POISE allows negative arguments, which shouldn't be allowed. It'd be better to change it so that if the user inputs a negative value, it defaults to meters since the ice sheet height is positive definite.

stellar/laboratory#363 (comment):

state is a term of art in React, so I avoid using that as the name. It might have been clearer to name this prop 'signatureCheckState' or something.