dapp

Right now env vars that accept boolean-esque values (like DAPP_TEST_FFI, HEVM_RPC, and DAPP_BUILD_OPTIMIZE) each require slightly different values to represent true.

Sometimes 1 means true, sometimes yes means true, sometimes any non 0 value means true, and sometimes the variable being set at all means true!

Ideally all boolean-esque env vars would only accept one of these value

We should apply sorting to the list of installed apps in the App Center (we "randomize" the discovery page to make it a bit more "fun"):

1. Upgrades available ahead of up to date apps
2. Alphabetical

cc @bpierre @dizzypaty I've also been wondering if it might be nice to start having sections in the App Center similar to Voting, for the different classes of apps (e.g. "ready" vs. "experiment

I left a review and then got this message

which seems strange as it's telling me something I know.

Some file is importing something from some test file. This means that we have to include the test directory in the published package, but besides that it's just a bad idea. I haven't looked into it, but it's probably easy to fix.

walletconnect always goes to rinkeby...

<UseWalletProvider
chainId={3}
connectors={{
walletconnect: {
rpcUrl:
'https://ropsten.infura.io/v3/7082b757ec2e4ebd8d47ca9518743623',
},
}}
>
...

onConnect={() => connect('walletconnect')}

But...

Response :
POST https://rinkeby.infura.io/v3/ 401 (Unauthorized

Expected Behavior

GoldWithdrawn, GoldLocked, GoldRelocked, GoldUnlocked should not emit when value is 0 (and corresponding operations should be prevented)

AccountsSlashed?

Current Behavior

Locked Celo operations are used to trace internal celo transfers by indexers, which leads to a false positive when value is 0

Discovered by coinbase in rosetta operation
See fix