Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate "eslint-plugin-eslint-comments" plugin #2049

Open
sogame opened this issue Jun 26, 2019 · 0 comments
Open

Integrate "eslint-plugin-eslint-comments" plugin #2049

sogame opened this issue Jun 26, 2019 · 0 comments

Comments

@sogame
Copy link

sogame commented Jun 26, 2019

When disabling some eslint rule, it's very easy to make mistakes like not enabling it again, forgetting to remove the disabled rule when the code is refactored...

eslint-plugin-eslint-comments checks those cases, allowing a safer way of disabling eslint rules: https://mysticatea.github.io/eslint-plugin-eslint-comments/rules/

I think it would be very useful to include it in eslint-config-airbnb-base (maybe just as a warning initially, to avoid a breaking change).

Before creating a PR adding it, I would like to gather feedback about it: do you think this would be a useful addition?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants
@sogame and others