[EH] Handle nested pops after inlining #4404
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Inlining creates additional
blocks at inlined call sites, which can beinside a
catch. For example:After inlining, this becomes
Now the
popis nested in ablock, which makes this invalid. This PRruns
EHUtils::handleBlockNestedPopsat the end to assign thepoptoa local right after the
catch, making the code valid again: