Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Add to mixin config" quick fix does not detect Fabric side annotations #1680

Open
Hubry opened this issue Oct 30, 2021 · 0 comments
Open

"Add to mixin config" quick fix does not detect Fabric side annotations #1680

Hubry opened this issue Oct 30, 2021 · 0 comments
Labels
status: accepted This is a high-priority feature or a reproduced bug type: bug

Comments

@Hubry
Copy link

Hubry commented Oct 30, 2021

When you create a mixin class on Fabric targetting a class marked with @net.fabricmc.api.Environment(net.fabricmc.api.EnvType.CLIENT), the quick fix suggests putting it on the common side. In Forge environments it suggests putting it on the client side.
From a cursory glance, it seems like the mixin inspection uses SideAnnotation.kt, which is only aware of Forge's annotations.

  • Plugin version: 2021.2-1.5.15
  • Target platform: Fabric

IntelliJ IDEA 2021.2.3 (Community Edition)
Build #IC-212.5457.46, built on October 12, 2021
Runtime version: 11.0.12+7-b1504.40 amd64
VM: OpenJDK 64-Bit Server VM by JetBrains s.r.o.
Windows 10 10.0
GC: G1 Young Generation, G1 Old Generation
Memory: 2042M
Cores: 8
Non-Bundled Plugins: org.toml.lang (0.2.155.4114-212), PMD-IDEA (1.7.0), com.github.b3er.idea.plugins.arc.browser (0.23), com.demonwav.minecraft-dev (2021.2-1.5.15), org.jetbrains.kotlin (212-1.5.31-release-546-IJ4638.7), izhangzhihao.rainbow.brackets (6.21)
Kotlin: 212-1.5.31-release-546-IJ4638.7

@DenWav DenWav added status: accepted This is a high-priority feature or a reproduced bug and removed status: unverified Needs triage labels Dec 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: accepted This is a high-priority feature or a reproduced bug type: bug
Projects
None yet
Development

No branches or pull requests

2 participants