child_process: apply hide_console_windows to spawnSync calls #41412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rzhao271
changed the title
kHideConsoleWindows should hide console windows for execSync and spawnSync calls as well. This fix adds on to nodejs#39712.
cjihrig
approved these changes
Jan 6, 2022
This comment has been minimized.
This comment has been minimized.
5 tasks
This comment has been minimized.
This comment has been minimized.
26 tasks
This comment has been minimized.
This comment has been minimized.
jasnell
approved these changes
Jan 17, 2022
16 tasks
This comment has been minimized.
This comment has been minimized.
13 tasks
17 tasks
|
Hi, is there anything else needed from me to get this PR merged? Thanks in advance. |
|
Hi @rzhao271, I am sorry this fell through. It's been marked as ready for a month, so I'll just restart CI and it should be good to go. |
25 tasks
22 tasks
|
Landed in 863d13c |
19 tasks
19 tasks
18 tasks
20 tasks
bengl
added a commit
to bengl/node
that referenced
this issue
Feb 21, 2022
kHideConsoleWindows should hide console windows for execSync and spawnSync calls as well. This fix adds on to nodejs#39712. PR-URL: nodejs#41412 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
bengl
added a commit
to bengl/node
that referenced
this issue
Feb 21, 2022
kHideConsoleWindows should hide console windows for execSync and spawnSync calls as well. This fix adds on to nodejs#39712. PR-URL: nodejs#41412 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
kHideConsoleWindows should hide console windows for
execSync and spawnSync calls as well. This fix adds on
to #39712.
I have confirmed the fix works downstream using Electron, but haven't yet built it or tested it in node itself.
Refs electron/electron#32340 and microsoft/vscode#138792
The text was updated successfully, but these errors were encountered: