Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[url_launcher] Mark Link as an invisible factory #4578

Merged
merged 6 commits into from Feb 4, 2022
Merged

[url_launcher] Mark Link as an invisible factory #4578

merged 6 commits into from Feb 4, 2022
+9 −3

Conversation

@hterkelsen
Copy link
Contributor

@hterkelsen hterkelsen commented Dec 4, 2021 •
edited

This improves performance, as the Flutter engine is given a signal that it doesn't need to create an overlay to render links.

This optimization requires flutter/engine#30003

Fixes flutter/flutter#94640

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.
hterkelsen added 2 commits Dec 3, 2021
@hterkelsen
[url_launcher] Mark Link as an invisible factory
78a1573 
This improves performance, as the Flutter engine is given a signal
that it doesn't need to create an overlay to render links.
@hterkelsen
Update pubspec and changelog
3d18f68
@flutter-dashboard
Copy link

@flutter-dashboard flutter-dashboard bot commented Dec 4, 2021

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@google-cla google-cla bot added the cla: yes label Dec 4, 2021
@stuartmorgan
Copy link
Contributor

@stuartmorgan stuartmorgan commented Dec 4, 2021

This optimization requires flutter/engine#30003

Looks like the PR will need to stay open until 2.9 or later reaches stable.

@godofredoc godofredoc changed the base branch from master to main Jan 6, 2022
@yjbanov
Copy link
Contributor

@yjbanov yjbanov commented Jan 21, 2022

Is it time to submit this?

@stuartmorgan
Copy link
Contributor

@stuartmorgan stuartmorgan commented Jan 21, 2022

Is it time to submit this?

Was it cherry-picked to 2.8? If not, we need to wait for the next stable release.

@ditman
Copy link
Member

@ditman ditman commented Jan 31, 2022

This and flutter/packages#529 are waiting for 2.10 to roll into stable.

@ditman ditman mentioned this pull request Jan 31, 2022
Merged
11 tasks
@ditman ditman self-assigned this Jan 31, 2022
@ditman
Copy link
Member

@ditman ditman commented Feb 3, 2022

Waiting for this benchmark to land:

flutter/flutter#94638

@ditman
Copy link
Member

@ditman ditman commented Feb 4, 2022

Updating PR

ditman
ditman approved these changes Feb 4, 2022
View changes
Copy link
Member

@ditman ditman left a comment

Let's go! 2.10 is already stable!

@fluttergithubbot fluttergithubbot merged commit c5c8cda into flutter:main Feb 4, 2022
56 checks passed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 4, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this issue Feb 4, 2022
@engine-flutter-autoroll
c5c8cda75 [url_launcher] Mark Link as an invisible factory (flutter/p…
4048be4 
…lugins#4578)
@stuartmorgan
Copy link
Contributor

@stuartmorgan stuartmorgan commented Feb 4, 2022

This breaks people who are still on 2.8, because the min Flutter version wasn't updated; we're getting reports about it.

While we don't officially support anything but latest stable, we ideally shouldn't leave people on older versions broken. I suggest reverting this (as a new version, which we publish), then re-landing with 2.10 minumum as another new version.

@stuartmorgan
Copy link
Contributor

@stuartmorgan stuartmorgan commented Feb 4, 2022

Actually, I forgot about the new retraction feature. I retracted 2.0.7, and we can just rev the min in a 2.0.8. I'll send a PR now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ditman ditman

Assignees

@ditman ditman

Labels
cla: yes last mile needs tests p: url_launcher platform-web waiting for tree to go green
Projects
None yet
Milestone
No milestone
5 participants
@hterkelsen @stuartmorgan @yjbanov @ditman @fluttergithubbot