New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
showcasing the Material2d abtraction with a new example: 2d/mesh2d_material.rs #3610
Open
eliotbo
wants to merge
10
commits into
bevyengine:main
Choose a base branch
from
eliotbo:main
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+124
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakobhellermann
suggested changes
Jan 9, 2022
Co-authored-by: Jakob Hellermann <jakob.hellermann@protonmail.com>
Co-authored-by: Jakob Hellermann <jakob.hellermann@protonmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Objective
Solution
The new 2d/mesh2d_material example is a modified version of the shader/shader_material example, where the Material trait is replaced by the Material2d trait. In the new example, users will be able to add fields to the Custom2dMaterial struct without having to change the Material2d and RenderAsset implementations, provided that bevy_crevice supports the type of said fields. This is achieved by 1) deriving AsStd140 on Custom2dMaterial, 2) setting the binding size with Custom2dMaterial::std140_size_static(), and 3) converting the entirety of the Custom2dMaterial data into std140 format with the derived as_std140() method. Of course, as users modify the Custom2dMaterial struct, they must also change the corresponding struct inside the shader script, but this exercise is left to them.