Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create an empty div.message-actions-container when no actions provided #140578

Merged
merged 1 commit into from Apr 7, 2022
Merged

Create an empty div.message-actions-container when no actions provided #140578

merged 1 commit into from Apr 7, 2022

Conversation

a-stewart
Copy link
Contributor

@a-stewart a-stewart commented Jan 12, 2022

This PR fixes #140577

@dbaeumer dbaeumer assigned lszomoru and unassigned dbaeumer Jan 13, 2022
@laurentlb
Copy link

@laurentlb laurentlb commented Feb 16, 2022

Thanks, it looks like a straight-forward fix.
@lszomoru, would you have time for a quick review?

@a-stewart
Copy link
Author

@a-stewart a-stewart commented Apr 6, 2022

Hi @lszomoru, was just wondering if would be able to take a quick look at this please :)

@lszomoru lszomoru added this to the April 2022 milestone Apr 7, 2022
@lszomoru lszomoru merged commit 583d7f3 into microsoft:main Apr 7, 2022
8 checks passed
@lszomoru
Copy link

@lszomoru lszomoru commented Apr 7, 2022

@a-stewart, sorry for the delay on getting this one merged.

@a-stewart
Copy link
Author

@a-stewart a-stewart commented Apr 7, 2022

No worries, thanks for merging :)

@a-stewart a-stewart deleted the fix-banner-no-actions branch Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lszomoru lszomoru

Labels
None yet
Projects
None yet
Milestone
April 2022
Development

Successfully merging this pull request may close these issues.

Banner Close icon does not float left if there are no actions.
5 participants
@a-stewart @laurentlb @lszomoru @dbaeumer @vscode-triage-bot