Opening this issue in case anyone wants to help. Recently, we've configured Storybook to import files from __examples__ folders inside Reakit component folders. This is how we're doing it:
Thos
Noticed this in reviewing #3165. In determining if an element is focused, axe-core looks at the disabled attribute. However it doesn't check if that attribute is allowed for the node. So the following link is incorrectly determined as not focusable:
<a href="foo.html" disabled>Hello</a>This bug exists in lib/commons/dom/focus-disabled.js. The fix is to check `vNode.props.nod
Running the WAVE plugin shows not all text has sufficient contrast, and an empty link is present, these are minor issues and potentially false positives, as the site may serve as an example for others it would be great if at least all errors from automated tests are resolved.
Running a tool such as the WAVE plugin on Chrome shows no errors.
In vscode, whenever I set the "extends" property in my tsconfig.json file, webhint gives the following error message:
Unexpected token } in JSON at position 705 (typescript-config/is-valid)
Really love this library, especially all the accessibility considerations built in! One thing I've noticed in implementing it though is an error from accessibility validators for a missing aria-valuenow property on both the Color and Hue sliders.
I had an explore of the MDN docs for the two properties
Add a description, image, and links to the a11y topic page so that developers can more easily learn about it.
To associate your repository with the a11y topic, visit your repo's landing page and select "manage topics."
The ability to view Storybook stories with different themes was added in grommet/grommet#5674.
We need to make adjustments to the stories component by component to take advantage of the theming ability. The Button stories are currently using this enhancement and can be viewed on storybook. While