Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed Visually out of place drop down in pull requests views with Safari #3244

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

Yash621
Copy link

@Yash621 Yash621 commented Jan 11, 2022

This PR is with respect to issue #2426

@alexr00 I have removed all the changes that are not related to fixing the bug,please review them.

let me know if any changes are required :)

@alexr00
Copy link
Member

@alexr00 alexr00 commented Jan 11, 2022

Looks like we lost some of the original styling (the arrow on the right of the select is gone):

image

The select now also has rounded corners, which isn't consistent with other selects in VS Code:
image

The colors look good though. Do you know if there's a way to fix the lost styling?

@Yash621
Copy link
Author

@Yash621 Yash621 commented Jan 11, 2022

@alexr00 sure , i would look into it and get back to you !

Copy link
Member

@alexr00 alexr00 left a comment

Thanks for the update! I'm seeing some style discrepancies, which I've left a comment on.

You can always push more commits to this PR and it will update, instead of creating a new PR each time :).

@Yash621
Copy link
Author

@Yash621 Yash621 commented Jan 20, 2022

@alexr00 I have tried to fix the styling but i am not getting like why the arrows have disappeared ,can you guide me on this ?

@alexr00
Copy link
Member

@alexr00 alexr00 commented Jan 21, 2022

@Yash621 I don't know why the arrows have disappeared off the top of my head so I don't have any guidance on this. I can do some digging into this later!

@Yash621
Copy link
Author

@Yash621 Yash621 commented Jan 21, 2022

@alexr00 Please see once ,and let me know as I have tried some approches but none is working so please let me know :)

@Yash621
Copy link
Author

@Yash621 Yash621 commented Feb 6, 2022

@alexr00 did you got any time to do some digging on why the arrows have disappeared ?

@alexr00
Copy link
Member

@alexr00 alexr00 commented Feb 7, 2022

@Yash621 not yet!

@Yash621 Yash621 closed this Feb 7, 2022
@Yash621 Yash621 reopened this Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants