mozilla

Steps to reproduce

1. Find an image with a long name e.g. https://en.wikipedia.org/wiki/Main_Page#/media/File:HMS_Seringapatam_at_anchor_in_Valetta_Harbour_-_Anton_Schranz.jpg
2. Save the image
3. Observe the notification after download is finished

Expected behaviour

The name is fully visible

Actual behaviour

The name is truncated
![262621408_944622912817064_909462865476

We currently implement createLogin() in a number of places. It would be nice to refactor this to a single place that can be shared everywhere as a utility function.

In URLExtensions.swift we have isIPv4 and isIPv6 functions. The first uses a regex and the second just checks for the presence of a : in the string. Let's replace this with a call to inet_pton() to let the OS parse the address instead - delegating to a trusted OS function will be more robust.

Example at https://stackoverflow.com/questions/35056268/how-to-use-swift-convert-string-to-ip

This issue was created automatically by a script.

Bug 1703773

Bug Reporter: @flodolo
CC: @mathjazz

Currently sync runs following the alphabetical order of language names, not locale codes. That's not intuitive, and makes debugging sync issues harder.