Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Convert to Python3. Use PEP8 naming conventions and formatting. #2
Conversation
|
|
||
| def boardID(path): | ||
|
|
||
| def board_id(path): |
khawley
May 14, 2018
Looks like the calls to the function didn't get renamed. (line 120 & line 179)
Looks like the calls to the function didn't get renamed. (line 120 & line 179)
|
I think you might have patched an old version, without .hex file support. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
I've been playing with CircuitPython and the Circuit Playground Express. Wanting to flash the device with a new build I ran across this script.
As a courtesy I've converted it from Python 2 (soon to be unsupported) to Python 3 (they tell me it's the future). I've also renamed a few things and changed formatting to conform roughly with the PEP8 Python style guide (https://www.python.org/dev/peps/pep-0008/).
There are no tests! However, I can only confirm the script converts a CircuitPython
.binfile to.uf2and that the device flashed with the resultingfirmware.uf2file works:I've made a cursory check with my eyeball Mk.1 but YMMV with the other functionality. Please check.
Thanks for the tool, the usefulness of uf2 and I hope this is helpful. :-)