web-padawan
Follow
web-padawan
Follow
Pinned
3,491 contributions in the last year
Less
More
Activity overview
Contributed to
vaadin/web-components,
modernweb-dev/web,
open-wc/api-viewer-element
and 5 other
repositories
Contribution activity
February 2022
Created 23 commits in 4 repositories
Created a pull request in vaadin/web-components that received 3 comments
test: rewrite date-picker keyboard tests to use sendKeys
Description
Before re-implementing the date-picker keyboard navigation, I decided to update existing tests:
Updated keyboard-input.test.js to use s…
+701
−578
•
3
comments
Opened 27 other pull requests in 4 repositories
vaadin/web-components
4
open
19
merged
1
closed
- refactor: remove iron-media-query from context-menu
- refactor: remove iron-media-query from crud
- refactor: remove iron-media-query from select
- feat: add controller to handle media queries
- test: add tests for reflecting properties
- refactor: remove unused private property
- chore: update dev dependencies versions
- fix: forward tabindex attribute to focusElement
- fix: restore old logic for getting focusable elements
- fix: handle list-box set before renderer
- fix: fire input event when clearing on Esc
- refactor: use toggle button click instead of tap
- refactor!: use rem for border-radius properties
- fix: do not open dropdown on helper click
- refactor: cleanup no longer used button roles
- fix: prevent input blur on calendar icon click (CP: 22.0) (#3398)
- fix: cleanup slot attribute on removed nodes (CP: 22.0) (#3396)
- fix: cleanup slot attribute on removed nodes
- test: add autoload helpers to Lumo and Material
- fix: improve drawer toggle ARIA attributes
- refactor: restore calendar date aria-label attribute
- test: use sendKeys for keyboard navigation tests
- refactor: use separate keydown event listeners
- refactor!: re-implement date-picker keyboard navigation
vaadin/flow-components
1
merged
vaadin/vaadin-select
1
merged
vaadin/vaadin-split-layout
1
open
Reviewed 41 pull requests in 6 repositories
vaadin/web-components
25 pull requests
- refactor: remove unused private property (#3420) (CP: 22.0)
- fix: forward tabindex attribute to focusElement (#3416) (CP: 22.0)
- fix: forward tabindex attribute to focusElement
- feat: make map accessible through keyboard
- fix: trigger size updates for map on resize
- fix: restore old logic for getting focusable elements
- fix: fire input event when clearing on Esc (#3408) (CP: 22.0)
- fix: do not open dropdown on helper click (#3402) (CP: 22.0)
- [date-picker] fix: prevent input blur on calendar icon click
- fix: add aria-label to crud sorter and filter
- fix: ensure OpenLayers instance is initialized before adding map to DOM
- chore: prevent fouc on dev pages
- chore: use lumo autoload helper in dev pages
- refactor!: re-implement date-picker keyboard navigation
- feat: announce file upload events
- fix: align footer border-radius with overlay container (#3360) (CP: 22.0)
- fix: only run the crud grid header renderer once (#3386) (CP: 22.0)
- fix: only run the crud grid header renderer once
- refactor: restore calendar date aria-label attribute
- chore: add standard lumo style sheets on dev pages
- test: remove non-null assertion in select types test
- fix: add aria-hidden to clear and toggle buttons (#3375)
- fix: add aria-hidden to clear and toggle buttons
- fix: position the material text-area bottom bar (#3359)
- fix: position the material text-area bottom bar
vaadin/flow-components
11 pull requests
- chore(deps-dev): bump gson from 2.8.5 to 2.8.9
- fix: make grid connector request content update on missing data (CP2)
- fix: clear selected key when item selected (#2618) (CP: 22.0)
- fix: avoid temporarily clearing the component renderer
- fix: add custom field when column has been added (#2493)
- fix: clear selected key when item selected
- fix: discard radios/checkboxes right before adding new ones (#2613) (CP: 22.0)
- fix: discard radios/checkboxes right before adding new ones
- feat: Add clearFilelist method
- fix: add aria-label to crud sorter and filter
- fix: remove child radios/checkboxes individually
modernweb-dev/web
2 pull requests
gatanaso/multiselect-combo-box
1 pull request
vaadin/platform
1 pull request
vaadin/vaadin-text-field
1 pull request
Created an issue in vaadin/web-components that received 1 comment
[lumo] Do not use border-radius properties to define margin
Motivation
Currently --lumo-border-radius-* properties are used in some rather unexpected places.
web-components/packages/vaadin-lumo-styles/mix…
1
comment