Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

composite example does not run in Windows #11849

Open
1 task done
robert-s-lee opened this issue Nov 10, 2021 · 4 comments · May be fixed by #13318
Open
1 task done

composite example does not run in Windows #11849

robert-s-lee opened this issue Nov 10, 2021 · 4 comments · May be fixed by #13318
Labels
actions content good first issue help wanted
Projects
Docs team reviews

Comments

@robert-s-lee
Copy link

@robert-s-lee robert-s-lee commented Nov 10, 2021

Code of Conduct

What article on docs.github.com is affected?

https://docs.github.com/en/actions/creating-actions/creating-a-composite-action

What part(s) of the article would you like to see updated?

Creating an action metadata file
 works for ubunut and mac. For windows, / does not work.

suggest the following change:

        - run: echo "${{ github.action_path }}" >> $GITHUB_PATH
          shell: bash          
        - run: goodbye.sh
          shell: bash

Additional information

No response
@welcome
Copy link

@welcome welcome bot commented Nov 10, 2021

Thanks for opening this issue. A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added this to Triage in Docs team reviews Nov 10, 2021
@ramyaparimi
Copy link
Collaborator

@ramyaparimi ramyaparimi commented Nov 11, 2021

@robert-s-lee
Thanks so much for opening an issue! I'll triage this for the team to take a look 👀

@hubwriter
Copy link
Contributor

@hubwriter hubwriter commented Dec 20, 2021

@robert-s-lee - Thank for raising this issue. I agree, your suggested change would avoid using the forward slash so would be usable across the OSs.

The change required is, therefore, as follows.

On lines 87-88 of the docs file content/actions/creating-actions/creating-a-composite-action.md, change:

- run: ${{ github.action_path }}/goodbye.sh
  shell: bash

to:

- run: echo "${{ github.action_path }}" >> $GITHUB_PATH
  shell: bash          
- run: goodbye.sh
  shell: bash

@docubot docubot moved this from Triage to Help wanted in Docs team reviews Dec 20, 2021
@kum9748ar
Copy link

@kum9748ar kum9748ar commented Dec 21, 2021

Hi, can I get started with this issue

adithyaakrishna added a commit to adithyaakrishna/github-docs that referenced this issue Dec 22, 2021
@adithyaakrishna
📝 - Updated Compositite Example on 🏁 - Fixes github#11849
b113efd 
Signed-off-by: Adithya Krishna <aadithya794@gmail.com>
@adithyaakrishna adithyaakrishna linked a pull request that will close this issue Dec 22, 2021
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
actions content good first issue help wanted
Projects
Docs team reviews
Help wanted
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

Bug - Updated Composite Example Content on Windows
4 participants
@robert-s-lee @ramyaparimi @hubwriter @kum9748ar