Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating ghcr_token to github_token #15082

Merged
merged 3 commits into from
Feb 7, 2022
Merged

Conversation

joshjohanning
Copy link
Contributor

@joshjohanning joshjohanning commented Feb 4, 2022

Why:

I think the ${{ secrets.ghcr_token }} is outdated, or at least not optimal. This assumes that you have a secret called ghcr_token and it doesn't specify you to create one.

It looks like this part of the doc was updated in Nov 2020 but since then, you can use the ${{ secrets.github_token }} to auth containers to GitHub Packages / GitHub Container Registry.

The ${{ secrets.github_token }} has write access to packages by default so this should work (and I have tested in my repo).

docker/docker.github.io updated their docs in June 2021; see:

What's being changed:

This changes ${{ secrets.ghcr_token }} to ${{ secrets.github_token }} in the jobs.<job_id>.container.credentials and jobs.<job_id>.services.<service_id>.credentials sections in the "Workflow syntax for GitHub Actions" page.

Check off the following:

  • I have reviewed my changes in staging (look for "Automatically generated comment" and click Modified to view your latest changes).
  • For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Feb 4, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Feb 4, 2022

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Staging Production What Changed
content/actions/using-workflows/workflow-syntax-for-github-actions.md Modified Original

@github-actions github-actions bot temporarily deployed to docs-15082--patch-3 February 4, 2022 16:49 Inactive
@ramyaparimi
Copy link
Contributor

@joshjohanning
Thanks so much for opening a PR! I'll get this triaged for review ⚡

@ramyaparimi ramyaparimi added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review actions This issue or pull request should be reviewed by the docs actions team and removed triage Do not begin working on this issue until triaged by the team labels Feb 4, 2022
Copy link
Member

@lecoursen lecoursen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'll merge this now. ⚡

@github-actions github-actions bot temporarily deployed to docs-15082--patch-3 February 7, 2022 19:41 Inactive
@lecoursen lecoursen merged commit bd8a817 into github:main Feb 7, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Feb 7, 2022

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants