-
Notifications
You must be signed in to change notification settings - Fork 60.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating ghcr_token to github_token #15082
Conversation
Automatically generated comment ℹ️This comment is automatically generated and will be overwritten every time changes are committed to this branch. The table contains an overview of files in the Content directory changesYou may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.
|
|
@joshjohanning |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I'll merge this now. ⚡
|
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡ |
Why:
I think the
${{ secrets.ghcr_token }}is outdated, or at least not optimal. This assumes that you have a secret calledghcr_tokenand it doesn't specify you to create one.It looks like this part of the doc was updated in Nov 2020 but since then, you can use the
${{ secrets.github_token }}to auth containers to GitHub Packages / GitHub Container Registry.The
${{ secrets.github_token }}has write access topackagesby default so this should work (and I have tested in my repo).docker/docker.github.io updated their docs in June 2021; see:
What's being changed:
This changes
${{ secrets.ghcr_token }}to${{ secrets.github_token }}in the jobs.<job_id>.container.credentials and jobs.<job_id>.services.<service_id>.credentials sections in the "Workflow syntax for GitHub Actions" page.Check off the following:
Writer impact (This section is for GitHub staff members only):