Skip to content
Permalink
development
Switch branches/tags

Commits on May 4, 2022

  1. Applied styleci changes

    ssddanbrown committed May 4, 2022
  2. Fixed double path slash URL issue in some cases

    - Occurred on system request path usage (Primarily on guest login
      redirection) when a custom path was not in use.
    - Added test to cover.
    
    For #3404
    ssddanbrown committed May 4, 2022

Commits on Apr 25, 2022

  1. Updated polymorphic database relation types to simpler version

    - Means we can use these simpler types in API response, As desired in #3377.
    
    Closes #3395
    ssddanbrown committed Apr 25, 2022
  2. Reviewed recycle bin API PR and made changes

    Made the following changes, many of these are just to align with
    existing conventions.
    
    - Updated urls to be hypenated, instead of underscored, to match other system endpoints.
    - Updated URL parameter to be `deletionId` instead of `id`, and removed the ID-based comment on controller methods, so the required ID model is clear from the URL alone, since its not clear from the URL endpoint alone like existing endpoints. This follows the pattern used in the "web" routes.
    - Added extra detail on some controller method comments, and copied permission comment to each method.
    - Removed existing field visibility mechanisms to use simpler model-based visibility since we didn't need anything too special here (After some of my other changes).
    - Allowed the "deletable" model to be shown in response to provide a little more detail on the main deleted item.
    - Updated parent/child-count loading to be on the "deletable" model instead of additional properties which results in simpler controller logic and enforces the idea these are relations on the deletable, not the deletion itself. It also removes additional exposure of model namespacing.
    - Updated (int) casts to intval, just since that's our most common conversion method in the codebase.
    - Testing: Removed `actingAsAuthorizedUser` and used the admin user instead to prevent extra auth steps on each test.
    - Testing: Cut logic/data-checks from tests if already covered by other tests.
    - Testing: Added simple assertions for delete/restore response data.
    - Examples: Updated list example to reflect changes.
    
    Review of PR #3377
    To be followed up with changes to polymorphic relations to hide
    namespacing.
    ssddanbrown committed Apr 25, 2022

Commits on Apr 24, 2022

  1. Merge pull request #3364 from BookStackApp/app_url_requests

    Updated custom request overrides to better match original intent
    ssddanbrown committed Apr 24, 2022
  2. Merge pull request #3387 from BookStackApp/editor_switching

    Page editor switching
    ssddanbrown committed Apr 24, 2022
  3. Merge pull request #3365 from BookStackApp/data_streaming

    Add data streaming where beneficial to reduce memory usage
    ssddanbrown committed Apr 24, 2022
  4. Merge pull request #3391 from BookStackApp/drawio_config_event

    Made it possible to configure draw.io/diagrams.net integration
    ssddanbrown committed Apr 24, 2022

Commits on Apr 23, 2022

  1. Switched to database-based tracking for page editor

    - Works better to avoid bad assumptions when showing the editor based
      upon content type.
    - Also updated some previous tests to cleaner format.
    ssddanbrown committed Apr 23, 2022
  2. Added listing of editor type to revisions

    - Also tweaked some editor revision table styles and merged some
      sections to reduce space usage.
    ssddanbrown committed Apr 23, 2022

Commits on Apr 21, 2022

Commits on Apr 20, 2022

  1. Made it possible to configure draw.io/diagrams.net integration

    Added new editor public event to hook into draw.io configuration step.
    Required change of embed url to trigger the configure step.
    ssddanbrown committed Apr 20, 2022
Older