ref(node): Don't return after process.exit #4512
Conversation
Any code after `process.exit(1)` is unreachable, so this return statement does nothing. We can remove it safely.
AbhiPrasad
requested review from
and
lobsterkatie (assigned from getsentry/team-web-sdk-frontend)
and removed request for
size-limit report
|
TS is happy with this? Once or twice I've come across a stray useless return statement and it's gotten mad when I've pulled it out - "not all code paths return a value," etc, etc. Here I'd hope it'd be smart enough to recognize that exit ends things, but you never know...
UPDATE: I guess if all the checks are passing, it's fine with it. Will mash approve.
|
Yeah it was actually my vscode's TS that complained. If we look at the node types, we can see that Might be missing something simple |
Any code after
process.exit(1)is unreachable, so this return statement does nothing. We can remove it safely.