Skip to content
#

tekton

Here are 128 public repositories matching this topic...

jx
ankitm123
ankitm123 commented Jan 5, 2022

Not sure what the error is, but lint passes in the CI and locally even if exported structs dont have comments.
Most probably, it's an issue with the golangci yaml config we use.

Also we use revive instead of golint (which is deprecated), may be some setting in revive needs to be enabled?

If we check the goreport card, we can see the issues: https://goreportcard.com/report/github.com/jenkins

chmouel
chmouel commented Jan 14, 2022

a lot new err/warnings with latest golangci-lint version 1.43.0 built from 861262b on 2021-11-12T10:37:23Z:

Linting go files...
WARN [runner] The linter 'golint' is deprecated (since v1.41.0) due to: The repository of the linter has been archived by the owner.  Replaced by revive.
test/e2e/task/start_test.go:1: File is not `gofmt`-ed with `-s` (gofmt)
// +build e2e
test/e2e/clustertas
mlx
Zachary-Fernandes
Zachary-Fernandes commented Nov 23, 2021

Describe the bug

When someone selects some assets from one menu displaying all assets of one type and then enters a menu displaying all assets of a different type, it will say there are selected assets of that type when none are currently selected in that menu.

To Reproduce

The below steps use datasets and pipelines as example asset types, but this can occur across any asset types

alexarnoldy
alexarnoldy commented Sep 13, 2021

The output for the fuseml workflow assign command is:
Workflow "ABC" assigned to codeset "relative-path/XYZ"

This would imply that the codeset is the structural object that the workflow runs on. Since the relationship is actually reverse of this, the output should be:
Codeset "relative-path/XYZ" assigned to workflow "ABC"

Improve this page

Add a description, image, and links to the tekton topic page so that developers can more easily learn about it.

Curate this topic

Add this topic to your repo

To associate your repository with the tekton topic, visit your repo's landing page and select "manage topics."

Learn more