Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(graphic): fix cursor doesn't work in graphic component. #16513

Merged
merged 2 commits into from Feb 16, 2022

Conversation

@plainheart
Copy link
Member

@plainheart plainheart commented Feb 15, 2022

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

Fix the bug that cursor doesn't work in graphic component.

Fixed issues

Details

Before: What was the problem?

After: How is it fixed in this PR?

Misc

  • The API has been changed (apache/echarts-doc#xxx).
  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

Please refer to the last case in test/graphic-cases.html.

Others

Merging options

  • Please squash the commits into a single one when merging.

Other information

Group doesn't support cursor/invisible/progressive as they are only for a single element. We should remove these options from our documentation.

@echarts-bot
Copy link

@echarts-bot echarts-bot bot commented Feb 15, 2022

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

pissang
pissang previously approved these changes Feb 16, 2022
@pissang pissang dismissed their stale review Feb 16, 2022

Added comment

@pissang pissang merged commit e4bdd30 into master Feb 16, 2022
1 check passed
@echarts-bot
Copy link

@echarts-bot echarts-bot bot commented Feb 16, 2022

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

@pissang pissang deleted the fix-graphic-cursor branch Feb 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants