Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report different sdk.name for NDK crashes #1901

Open
bruno-garcia opened this issue Feb 9, 2022 · 3 comments
Open

Report different sdk.name for NDK crashes #1901

bruno-garcia opened this issue Feb 9, 2022 · 3 comments

Comments

@bruno-garcia
Copy link
Member

bruno-garcia commented Feb 9, 2022

NDK crashes are captured by sentry-native and reported as sentry.native. This makes it hard to distinguish by builds bundled by the Android SDK (which are in fact using a different mechanism/backend to capture as any build documented directly on sentry-native repo.

I suggest we have a #ifdef that allows us to change the SDK name to sentry.native.android when building in this repository.

@bruno-garcia bruno-garcia added NDK Android NDK enhancement New feature or request labels Feb 9, 2022
@marandaneto
Copy link
Member

marandaneto commented Feb 10, 2022

@bruno-garcia
Copy link
Member Author

bruno-garcia commented Feb 10, 2022

@marandaneto yes, and some bits here, defining the constant for example

@bruno-garcia
Copy link
Member Author

bruno-garcia commented Mar 7, 2022

When a version after 0.4.15 is released, it should already report sentry.native.android: #1901

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Blocked
Development

No branches or pull requests

2 participants